Attachment 129930 Details for Bug 29058 – Bug 29058: Don't display 'Always show holds' at the bottom of the patron list

[patch] Bug 29058: Don't display 'Always show holds' at the bottom of the patron list

Bug-29058-Dont-display-Always-show-holds-at-the-bo.patch (text/plain), 2.72 KB, created by Jonathan Druart on 2022-01-28 12:48:34 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Jonathan Druart

Created: 2022-01-28 12:48:34 UTC

Size: 2.72 KB

patch

obsolete

>From 21c098e90137252a279f8c656bb7d7d794b57db5 Mon Sep 17 00:00:00 2001
>From: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
>Date: Fri, 28 Jan 2022 13:47:35 +0100
>Subject: [PATCH] Bug 29058: Don't display 'Always show holds' at the bottom of
> the patron list
>
>The checkbox should not appear if we are selecting a patron
>
>Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
>---
> .../prog/en/modules/reserve/request.tt        | 20 ++++++++++---------
> 1 file changed, 11 insertions(+), 9 deletions(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt
>index 1afeb692867..16348f3bdd5 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt
>@@ -905,16 +905,18 @@
>             [% END %]
> 
>             [% UNLESS ( patron ) %]
>-                [% SET hold_count = Biblio.HoldsCount( biblio.biblionumber ) | html %]
>-                [% IF hold_count %]
>-                    <label for ="always_show_holds">Always show holds</label>
>-                    [% IF always_show_holds == 'DONT' %]
>-                        <input type="checkbox" name="always_show_holds" id="always_show_holds" value="DO">
>-                        [% UNLESS reserveloop %]
>-                            <a class="btn btn-default" value="Show holds" id="show_holds_now" href="/cgi-bin/koha/reserve/request.pl?biblionumber=[% biblio.biblionumber %]&show_holds_now=1">Show holds ([% hold_count %])</a>
>+                [% UNLESS borrowers %]
>+                    [% SET hold_count = Biblio.HoldsCount( biblio.biblionumber ) | html %]
>+                    [% IF hold_count %]
>+                        <label for ="always_show_holds">Always show holds</label>
>+                        [% IF always_show_holds == 'DONT' %]
>+                            <input type="checkbox" name="always_show_holds" id="always_show_holds" value="DO">
>+                            [% UNLESS reserveloop %]
>+                                <a class="btn btn-default" value="Show holds" id="show_holds_now" href="/cgi-bin/koha/reserve/request.pl?biblionumber=[% biblio.biblionumber %]&show_holds_now=1">Show holds ([% hold_count %])</a>
>+                            [% END %]
>+                        [% ELSE %]
>+                            <input type="checkbox" name="always_show_holds" value="DO" id="always_show_holds" checked="checked">
>                         [% END %]
>-                    [% ELSE %]
>-                        <input type="checkbox" name="always_show_holds" value="DO" id="always_show_holds" checked="checked">
>                     [% END %]
>                 [% END %]
>                 [% IF ( reserveloop ) %]
>-- 
>2.25.1

Actions: View | Diff | Splinter Review

Attachments on bug 29058: 125054 | 125062 | 125091 | 125487 | 125488 | 126995 | 129924 | 129925 | 129930 | 129931 | 129932 | 129933