Bugzilla – Attachment 129993 Details for
Bug 28832
[21.05] Batch modification always clears permanent_location if it is mapped in frameworks
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 28832: (follow-up) Don't remove false values, only empty strings
Bug-28832-follow-up-Dont-remove-false-values-only-.patch (text/plain), 1.18 KB, created by
Martin Renvoize (ashimema)
on 2022-01-31 10:20:07 UTC
(
hide
)
Description:
Bug 28832: (follow-up) Don't remove false values, only empty strings
Filename:
MIME Type:
Creator:
Martin Renvoize (ashimema)
Created:
2022-01-31 10:20:07 UTC
Size:
1.18 KB
patch
obsolete
>From a91deb3ea51d475fb6071add0bf02d76e02147f9 Mon Sep 17 00:00:00 2001 >From: Nick Clemens <nick@bywatersolutions.com> >Date: Wed, 24 Nov 2021 16:05:23 +0000 >Subject: [PATCH] Bug 28832: (follow-up) Don't remove false values, only empty > strings > >Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> >--- > tools/batchMod.pl | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > >diff --git a/tools/batchMod.pl b/tools/batchMod.pl >index e21b0e8299..bf415c2ea7 100755 >--- a/tools/batchMod.pl >+++ b/tools/batchMod.pl >@@ -123,13 +123,14 @@ if ($op eq "action") { > > # Clear the fields we are not editing, leave fields we are blanking > foreach( my $i = 0; $i < scalar @values; $i++ ){ >- unless( $values[$i] || $searches[$i] || grep { $subfields[$i] } @disabled ){ >+ unless( $values[$i] ne q{} || $searches[$i] ne q{} || grep { $subfields[$i] } @disabled ){ > splice(@values,$i,1); > splice(@subfields,$i,1); > splice(@tags,$i,1); > splice(@searches,$i,1); > splice(@replaces,$i,1); > splice(@modifiers,$i,1); >+ $i--; # We made the arrays smaller - go back a step in interation > } > } > >-- >2.20.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 28832
:
123654
|
123966
|
123982
|
125075
|
125076
|
125077
|
127982
|
129991
|
129992
| 129993 |
129994