Bugzilla – Attachment 130090 Details for
Bug 29975
(Bug 21729 followup) patron_expiration_date missing in API
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 29975: Add missing patron_expiration_date attribute to hold spec
Bug-29975-Add-missing-patronexpirationdate-attribu.patch (text/plain), 1.25 KB, created by
Tomás Cohen Arazi (tcohen)
on 2022-02-02 12:14:33 UTC
(
hide
)
Description:
Bug 29975: Add missing patron_expiration_date attribute to hold spec
Filename:
MIME Type:
Creator:
Tomás Cohen Arazi (tcohen)
Created:
2022-02-02 12:14:33 UTC
Size:
1.25 KB
patch
obsolete
>From 5c25489029e4969f30c0253111ff73433b36a627 Mon Sep 17 00:00:00 2001 >From: Tomas Cohen Arazi <tomascohen@theke.io> >Date: Wed, 2 Feb 2022 09:12:40 -0300 >Subject: [PATCH] Bug 29975: Add missing patron_expiration_date attribute to > hold spec > >On bug 21729 a new attribute was added to the holds objects, but we >forgot to add it to the spec. This broke the holds routes. > >To test: >1. Run: > $ kshell > k$ prove t/db_dependent/api/v1/holds.t >=> FAIL: Tests fail, boo. >2. Apply this patch >3. Repeat 1 >=> SUCCESS: Tests pass! >4. Sign off :-D > >Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> >--- > api/v1/swagger/definitions/hold.yaml | 6 ++++++ > 1 file changed, 6 insertions(+) > >diff --git a/api/v1/swagger/definitions/hold.yaml b/api/v1/swagger/definitions/hold.yaml >index 1ca8114cf3..13d9119f89 100644 >--- a/api/v1/swagger/definitions/hold.yaml >+++ b/api/v1/swagger/definitions/hold.yaml >@@ -74,6 +74,12 @@ properties: > - "null" > format: date > description: The date the hold expires >+ patron_expiration_date: >+ type: >+ - string >+ - "null" >+ format: date >+ description: The date the patron requested the hold expires > lowest_priority: > type: boolean > description: Controls if the hold is given the lowest priority on the queue >-- >2.32.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 29975
:
129961
|
129988
|
130058
|
130090
|
130092