Attachment 130114 Details for Bug 29066 – Bug 29066: Remove text in OPAC search form and use Font Awesome icons

[patch] Bug 29066: Remove text in OPAC search form and use Font Awesome icons

Bug-29066-Remove-text-in-OPAC-search-form-and-use-.patch (text/plain), 5.47 KB, created by Lucas Gass (lukeg) on 2022-02-02 14:58:36 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Lucas Gass (lukeg)

Created: 2022-02-02 14:58:36 UTC

Size: 5.47 KB

patch

obsolete

>From 4002267751e1b14422a7900c728f93486fd21fe0 Mon Sep 17 00:00:00 2001
>From: Fridolin Somers <fridolin.somers@biblibre.com>
>Date: Mon, 20 Sep 2021 12:33:05 -1000
>Subject: [PATCH] Bug 29066: Remove text in OPAC search form and use Font
> Awesome icons
>
>In modern front-end websites, first think you see in header region is an large input text with a search icon.
>No need to say it is a search form.
>We still tell it in 'title' attribut for accessibility.
>
>This patch removes 'Search' text.
>If 'my library first' feature is enabled, shows a text in title of a
>question mark icon.
>In submit button, replaces 'Go' with a seach icon and add title
>'Search'.
>
>Test plan :
>1)
>1.1) Set system preferences :
>  OpacAddMastheadLibraryPulldown to 'Add'
>  SearchMyLibraryFirst to 'Don't limit'
>1.2) Go to OPAC main page
>1.3) You don't see 'Search' anymore
>1.4) You see in submit button an icon
>1.5) Move mouse over submit button to see tooltip text 'Search'
>2)
>2.1) Set system preferences :
>  OpacAddMastheadLibraryPulldown to 'Don't add'
>  SearchMyLibraryFirst to 'Limit'
>2.2) Go to OPAC main page
>2.3) Log in
>2.4) You don't see text 'Search (in <library name>) only'
>2.5) You see a question mark icon
>2.6) Move mouse over submit button to see tooltip text 'Search (in <library name>) only'
>
>Signed-off-by: Samu Heiskanen <samu.heiskanen@hypernova.fi>
>
>Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
>---
> .../bootstrap/en/includes/masthead.inc        | 25 ++++++++++---------
> 1 file changed, 13 insertions(+), 12 deletions(-)
>
>diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/includes/masthead.inc b/koha-tmpl/opac-tmpl/bootstrap/en/includes/masthead.inc
>index e75c419734..f5109ba972 100644
>--- a/koha-tmpl/opac-tmpl/bootstrap/en/includes/masthead.inc
>+++ b/koha-tmpl/opac-tmpl/bootstrap/en/includes/masthead.inc
>@@ -164,13 +164,13 @@
>                                     <form name="searchform" method="get" action="/cgi-bin/koha/opac-search.pl" id="searchform">
>                                         <div class="form-row align-items-center">
>                                             <div class="col-sm-auto order-1 order-sm-1">
>-                                                <label for="masthead_search"> Search
>-                                                    [% UNLESS ( Koha.Preference( 'OpacAddMastheadLibraryPulldown' ) == 1 ) %]
>-                                                        [% IF ( mylibraryfirst ) %]
>-                                                            (in [% Branches.GetName( mylibraryfirst ) | html %] only)
>-                                                        [% END %]
>+                                                [% UNLESS ( Koha.Preference( 'OpacAddMastheadLibraryPulldown' ) == 1 ) %]
>+                                                    [% IF ( mylibraryfirst ) %]
>+                                                        <span title="Search in [% Branches.GetName( mylibraryfirst ) | html %] only">
>+                                                            <i class="fa fa-question-circle-o"></i>
>+                                                        </span>
>                                                     [% END %]
>-                                                </label>
>+                                                [% END %]
>                                             </div>
>                                             <div class="col-sm-auto order-2 order-sm-2">
>                                                 <select name="idx" id="masthead_search" class="form-control">
>@@ -262,9 +262,6 @@
>                                                         [% END # / BranchCategoriesLoop %]
>                                                     </select> 
>                                                 </div> 
>-                                                <div class="col-sm-auto order-5">
>-                                                    <button type="submit" id="searchsubmit" class="btn btn-primary">Go</button>
>-                                                </div>
>                                             [% ELSE %]
>                                                 [% IF ( opac_limit_override ) %]
>                                                     [% IF ( opac_search_limit ) %]
>@@ -279,10 +276,14 @@
>                                                         <input name="limit" value="branch:[% mylibraryfirst | html %]" type="hidden" />
>                                                     [% END %]
>                                                 [% END # / opac_limit_override %]
>-                                                <div class="order-5 col-sm-auto">
>-                                                    <button type="submit" id="searchsubmit" class="btn btn-primary">Go</button>
>-                                                </div>
>                                             [% END # / OpacAddMastheadLibraryPulldown %]
>+
>+                                            <div class="order-5 col-sm-auto">
>+                                                <button type="submit" id="searchsubmit" class="btn btn-primary" title="Search">
>+                                                    <i class="fa fa-search"></i>
>+                                                </button>
>+                                            </div>
>+
>                                         </div> 
>                                         <input type="hidden" name="weight_search" value="1">
>                                     </form>
>-- 
>2.20.1

Actions: View | Diff | Splinter Review

Attachments on bug 29066: 125084 | 125180 | 125181 | 128927 | 129519 | 130031 | 130032 | 130114 | 130115 | 132375 | 132376 | 132377 | 132854 | 132855 | 132947