Attachment 130115 Details for Bug 29066 – Bug 29066: (follow-up) add aria-label and aria-hidden on icons

[patch] Bug 29066: (follow-up) add aria-label and aria-hidden on icons

Bug-29066-follow-up-add-aria-label-and-aria-hidden.patch (text/plain), 2.19 KB, created by Lucas Gass (lukeg) on 2022-02-02 14:58:39 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Lucas Gass (lukeg)

Created: 2022-02-02 14:58:39 UTC

Size: 2.19 KB

patch

obsolete

>From cd19a73a5ff9866453939a2c32484249c6f762fc Mon Sep 17 00:00:00 2001
>From: Fridolin Somers <fridolin.somers@biblibre.com>
>Date: Fri, 14 Jan 2022 20:53:54 -1000
>Subject: [PATCH] Bug 29066: (follow-up) add aria-label and aria-hidden on
> icons
>
>Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
>---
> koha-tmpl/opac-tmpl/bootstrap/en/includes/masthead.inc | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
>diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/includes/masthead.inc b/koha-tmpl/opac-tmpl/bootstrap/en/includes/masthead.inc
>index f5109ba972..ec5f4779bc 100644
>--- a/koha-tmpl/opac-tmpl/bootstrap/en/includes/masthead.inc
>+++ b/koha-tmpl/opac-tmpl/bootstrap/en/includes/masthead.inc
>@@ -167,7 +167,7 @@
>                                                 [% UNLESS ( Koha.Preference( 'OpacAddMastheadLibraryPulldown' ) == 1 ) %]
>                                                     [% IF ( mylibraryfirst ) %]
>                                                         <span title="Search in [% Branches.GetName( mylibraryfirst ) | html %] only">
>-                                                            <i class="fa fa-question-circle-o"></i>
>+                                                            <i class="fa fa-question-circle-o" aria-hidden="true"></i>
>                                                         </span>
>                                                     [% END %]
>                                                 [% END %]
>@@ -279,8 +279,8 @@
>                                             [% END # / OpacAddMastheadLibraryPulldown %]
> 
>                                             <div class="order-5 col-sm-auto">
>-                                                <button type="submit" id="searchsubmit" class="btn btn-primary" title="Search">
>-                                                    <i class="fa fa-search"></i>
>+                                                <button type="submit" id="searchsubmit" class="btn btn-primary" title="Search" aria-label="Search">
>+                                                    <i class="fa fa-search" aria-hidden="true"></i>
>                                                 </button>
>                                             </div>
> 
>-- 
>2.20.1

Actions: View | Diff | Splinter Review

Attachments on bug 29066: 125084 | 125180 | 125181 | 128927 | 129519 | 130031 | 130032 | 130114 | 130115 | 132375 | 132376 | 132377 | 132854 | 132855 | 132947