Attachment 130143 Details for Bug 29844 – Bug 29844: (QA follow-up) Fix Koha::Library::Groups->all_libraries

[patch] Bug 29844: (QA follow-up) Fix Koha::Library::Groups->all_libraries

Bug-29844-QA-follow-up-Fix-KohaLibraryGroups-allli.patch (text/plain), 1.08 KB, created by Tomás Cohen Arazi (tcohen) on 2022-02-03 13:32:15 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Tomás Cohen Arazi (tcohen)

Created: 2022-02-03 13:32:15 UTC

Size: 1.08 KB

patch

obsolete

>From b0b7a9225853775b8d247e1d84d4bd3f49fd7e24 Mon Sep 17 00:00:00 2001
>From: Martin Renvoize <martin.renvoize@ptfs-europe.com>
>Date: Thu, 3 Feb 2022 12:13:20 +0000
>Subject: [PATCH] Bug 29844: (QA follow-up) Fix
> Koha::Library::Groups->all_libraries
>
>I think a rebase perhaps lost a change here.. this fix gets the unit
>tests passing again.
>
>Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
>Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
>---
> Koha/Library/Group.pm | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
>diff --git a/Koha/Library/Group.pm b/Koha/Library/Group.pm
>index a486d35ecc..f85d715dbb 100644
>--- a/Koha/Library/Group.pm
>+++ b/Koha/Library/Group.pm
>@@ -144,8 +144,8 @@ sub all_libraries {
> 
>     my @libraries;
> 
>-    push (@libraries, $self->libraries);
>-    my @children = $self->children->search({ branchcode => undef });
>+    push (@libraries, $self->libraries->as_list);
>+    my @children = $self->children->search({ branchcode => undef })->as_list;
>     foreach my $c (@children) {
>         push( @libraries, $c->all_libraries );
>     }
>-- 
>2.32.0

Actions: View | Diff | Splinter Review

Attachments on bug 29844: 129285 | 129286 | 129287 | 129290 | 129291 | 129292 | 129293 | 129295 | 129996 | 129997 | 129998 | 129999 | 130098 | 130099 | 130100 | 130101 | 130129 | 130130 | 130131 | 130132 | 130133 | 130134 | 130135 | 130136 | 130137 | 130138 | 130139 | 130143 | 130145 | 130146 | 130481 | 130947 | 131032