Bugzilla – Attachment 130149 Details for
Bug 29859
Favor iterators over as_list
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 29859: (QA follow-up) Minor typo correction
Bug-29859-QA-follow-up-Minor-typo-correction.patch (text/plain), 900 bytes, created by
Martin Renvoize (ashimema)
on 2022-02-03 15:13:23 UTC
(
hide
)
Description:
Bug 29859: (QA follow-up) Minor typo correction
Filename:
MIME Type:
Creator:
Martin Renvoize (ashimema)
Created:
2022-02-03 15:13:23 UTC
Size:
900 bytes
patch
obsolete
>From 59a2ef88722c1bb0c80ebd24490b18221212a762 Mon Sep 17 00:00:00 2001 >From: Martin Renvoize <martin.renvoize@ptfs-europe.com> >Date: Thu, 3 Feb 2022 14:43:13 +0000 >Subject: [PATCH] Bug 29859: (QA follow-up) Minor typo correction > >We introduced a tiny bug with a typo in the patchset, the accessor >method is called 'get_column' not 'get_columns'. > >Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> >--- > Koha/Holds.pm | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/Koha/Holds.pm b/Koha/Holds.pm >index d2cea098cf..187e61bbc7 100644 >--- a/Koha/Holds.pm >+++ b/Koha/Holds.pm >@@ -123,7 +123,7 @@ sub get_items_that_can_fill { > columns => ['itemnumber'], > collapse => 1, > } >- )->get_columns('itemnumber'); >+ )->get_column('itemnumber'); > my @waiting_holds = Koha::Holds->search( > { 'found' => 'W' }, > { >-- >2.20.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 29859
:
129346
|
129350
|
130102
|
130148
| 130149 |
130480
|
130483
|
132972
|
132983