Attachment 130187 Details for Bug 29504 – Bug 29504: Allow 'ADDITIONAL_MATERIALS' check to be confirmed

[patch] Bug 29504: Allow 'ADDITIONAL_MATERIALS' check to be confirmed

Bug-29504-Allow-ADDITIONALMATERIALS-check-to-be-co.patch (text/plain), 2.60 KB, created by David Nind on 2022-02-05 13:36:52 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: David Nind

Created: 2022-02-05 13:36:52 UTC

Size: 2.60 KB

patch

obsolete

>From c8192140f517e3bdadfc24fb6545d1a0ed9ecee8 Mon Sep 17 00:00:00 2001
>From: Martin Renvoize <martin.renvoize@ptfs-europe.com>
>Date: Mon, 22 Nov 2021 11:33:25 +0000
>Subject: [PATCH] Bug 29504: Allow 'ADDITIONAL_MATERIALS' check to be confirmed
>
>The additional materials check when CircConfirmParts is enabled was
>errantly relying upon the 'FORCE_CHECKOUT' permission.  This patch
>updates the template to allow confirmation as well as cancellation of
>chekout.
>
>Test plan
>1. Set a staff member with circ permissions, but not FORCE_CHECKOUT
>2. Turn on CircConfirmItemParts
>3. Log in as staff member in step 1
>4. Attempt to checkout an item with a 952$3
>5. The only option given is the Continue button (with a red X) and when
>   clicked, the item does not get checked out.
>6. Apply patch
>7. Repeat step 4.
>8. You should now have the option to 'Yes, check out (Y)' or
>   'No, don't check out (N)'
>
>Signed-off-by: David Nind <david@davidnind.com>
>---
> koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt
>index a5ada8c27b..b1d764fb68 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt
>@@ -235,7 +235,7 @@
>                                 [% END %]
>                             </ul>
> 
>-                            [% IF CAN_user_circulate_force_checkout or HIGHHOLDS %]
>+                            [% IF CAN_user_circulate_force_checkout or HIGHHOLDS or ADDITIONAL_MATERIALS %]
>                                 <form method="post" action="/cgi-bin/koha/circ/circulation.pl" autocomplete="off">
>                                     <input type="hidden" name="restoreduedatespec" />
> 
>@@ -328,7 +328,7 @@
>                                 <input type="hidden" name="duedatespec" value="[% duedatespec | html %]" />
>                                 <input type="hidden" name="restoreduedatespec" />
>                                 <input type="hidden" name="stickyduedate" value="[% stickyduedate | html %]" />
>-                                [% IF CAN_user_circulate_force_checkout or HIGHHOLDS %]
>+                                [% IF CAN_user_circulate_force_checkout or HIGHHOLDS or ADDITIONAL_MATERIALS %]
>                                     [% IF ( RENEW_ISSUE ) %]
>                                         <button type="submit" class="deny" accesskey="n"><i class="fa fa-times"></i> No, don't renew (N)</button>
>                                     [% ELSE %]
>-- 
>2.30.2

Actions: View | Diff | Splinter Review

Attachments on bug 29504: 127926 | 128549 | 128550 | 130187 | 130188 | 136330 | 136331