Attachment 130267 Details for Bug 29843 – Bug 29843: Use in opac/opac-privacy.pl

[patch] Bug 29843: Use in opac/opac-privacy.pl

Bug-29843-Use-in-opacopac-privacypl.patch (text/plain), 1.86 KB, created by Martin Renvoize (ashimema) on 2022-02-08 09:40:11 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Martin Renvoize (ashimema)

Created: 2022-02-08 09:40:11 UTC

Size: 1.86 KB

patch

obsolete

>From 55fccc518cf4a8607f9d32248765b99463a7f67e Mon Sep 17 00:00:00 2001
>From: Tomas Cohen Arazi <tomascohen@theke.io>
>Date: Mon, 10 Jan 2022 11:44:07 -0300
>Subject: [PATCH] Bug 29843: Use in opac/opac-privacy.pl
>
>This patch makes the opac/opac-privacy.pl OPAC page use the new
>anonymize method.
>
>To test:
>1. Have some checked-in materiales
>2. Have OPACPrivacy enabled
>3. Notice your checkouts history contains what you expect
>4. Go to 'your privacy'
>5. Click on 'Delete checkout history'
>=> SUCCESS: It works, no crash.
>6. Sign off :-D
>
>Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com>
>Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
>---
> opac/opac-privacy.pl | 9 +++------
> 1 file changed, 3 insertions(+), 6 deletions(-)
>
>diff --git a/opac/opac-privacy.pl b/opac/opac-privacy.pl
>index 2c96b7ffa9..b3ba672afe 100755
>--- a/opac/opac-privacy.pl
>+++ b/opac/opac-privacy.pl
>@@ -40,13 +40,13 @@ my ( $template, $borrowernumber, $cookie ) = get_template_and_user(
>     }
> );
> 
>-my $patron = Koha::Patrons->find( $borrowernumber );
>-
> my $op                         = $query->param("op");
> my $privacy                    = $query->param("privacy");
> my $privacy_guarantor_checkouts = $query->param("privacy_guarantor_checkouts");
> my $privacy_guarantor_fines     = $query->param("privacy_guarantor_fines");
> 
>+my $patron = Koha::Patrons->find( $borrowernumber );;
>+
> if ( $op eq "update_privacy" ) {
>     if ( $patron ) {
>         $patron->set({
>@@ -69,10 +69,7 @@ elsif ( $op eq "delete_record" ) {
>     if ( $all or $checkouts ) {
> 
>         # delete all reading records for items returned
>-        my $rows = eval {
>-            Koha::Patrons->search( { 'me.borrowernumber' => $borrowernumber } )
>-              ->anonymise_issue_history;
>-        };
>+        my $rows = eval { $patron->old_checkouts->anonymize + 0 };
> 
>         $template->param(
>             (
>-- 
>2.20.1

Actions: View | Diff | Splinter Review

Attachments on bug 29843: 129269 | 129270 | 129271 | 129272 | 129274 | 129275 | 129276 | 129277 | 129278 | 129438 | 129439 | 129440 | 129441 | 129442 | 129445 | 129446 | 129447 | 129448 | 129449 | 129475 | 129476 | 129477 | 129478 | 129479 | 129492 | 129493 | 129494 | 129495 | 129496 | 130264 | 130265 | 130266 | 130267 | 130268 | 130335