Attachment 130306 Details for Bug 28576 – Bug 28576: Add patron image in patron detail section does not specify image size limit

[patch] Bug 28576: Add patron image in patron detail section does not specify image size limit

Bug-28576-Add-patron-image-in-patron-detail-sectio.patch (text/plain), 2.69 KB, created by Martin Renvoize (ashimema) on 2022-02-08 16:05:57 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Martin Renvoize (ashimema)

Created: 2022-02-08 16:05:57 UTC

Size: 2.69 KB

patch

obsolete

>From 6ca1d39b18450990184a5ddb5c875960425e63c8 Mon Sep 17 00:00:00 2001
>From: Salman Ali <salman.ali@inLibro.com>
>Date: Wed, 16 Jun 2021 13:20:24 -0400
>Subject: [PATCH] Bug 28576: Add patron image in patron detail section does not
> specify image size limit
>
>When you try to add an image to a patron in Home/Patrons/anyPatron, it only states the file types that are supported but not the maximum size. If you try to add an image that is bigger than 500 kb, nothing happens and the reason is not presented.
>
>This is not the case with the 2 other places where we can add patron images in which they give warnings:
>Home/Tools/Upload patron images
>Home/Tools/Patron card creator/Images
>
>For now, i simply added the size limit to the file supported message.
>
>To test:
>1)Search for any patron and go to his page
>2)Hover over the image area on the left and click on add
>3)Notice the message above the choose file button only specifies file types not size.
>4)Add an image bigger than 500 kb
>5)Nothing happens
>6)Apply patch
>7)Repeat steps from 1 to 3
>8)Notice the message now includes the maximum size
>
>Signed-off-by: David Nind <david@davidnind.com>
>Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
>Signed-off-by: David Nind <david@davidnind.com>
>Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
>---
> koha-tmpl/intranet-tmpl/prog/en/modules/members/moremember.tt | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/members/moremember.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/members/moremember.tt
>index 951c3e1023..202f54a401 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/members/moremember.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/members/moremember.tt
>@@ -276,7 +276,7 @@
>                                             [% ELSE %]
>                                                 <div class="hint">[% patron.title | html %] [% patron.firstname | html %] [% patron.surname | html %] does not currently have an image available. To import an image for [% patron.title | html %] [% patron.firstname | html %] [% patron.surname | html %], enter the name of an image file to upload.</div>
>                                             [% END %]
>-                                            <p>Only PNG, GIF, JPEG, XPM formats are supported.</p>
>+                                            <p>Only PNG, GIF, JPEG, XPM formats are supported. Maximum image size is 500KB.</p>
>                                             <label for="uploadfile">Select the file to upload: </label>
>                                             <input type="file" id="uploadfile" name="uploadfile" required="required" />
>                                             <div class="action">
>-- 
>2.20.1

Actions: View | Diff | Splinter Review

Attachments on bug 28576: 122048 | 122192 | 122423 | 122618 | 122759 | 130054 | 130088 | 130089 | 130306 | 130307