Bugzilla – Attachment 130310 Details for
Bug 29570
Unable to sort summary column of pending_orders table on parcel.pl by summary column
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 29570: Enable sorting orders by summary
Bug-29570-Enable-sorting-orders-by-summary.patch (text/plain), 2.23 KB, created by
Jonathan Druart
on 2022-02-08 16:36:05 UTC
(
hide
)
Description:
Bug 29570: Enable sorting orders by summary
Filename:
MIME Type:
Creator:
Jonathan Druart
Created:
2022-02-08 16:36:05 UTC
Size:
2.23 KB
patch
obsolete
>From 95833b608e019107fa19e32fb4f46432965367c3 Mon Sep 17 00:00:00 2001 >From: Tomas Cohen Arazi <tomascohen@theke.io> >Date: Wed, 2 Feb 2022 17:10:36 -0300 >Subject: [PATCH] Bug 29570: Enable sorting orders by summary > >This patch enables (on receiving) sorting orders by the summary column. >It needs the previous patches to work. Title is given more precedence as >expressed by users on the bug report. Which, by the way, makes sense. > >To test: >1. Create a basket >2. Create orders >3. Close basket >4. Receive shipment >5. Enter invoice information >=> SUCCESS: You should see your pending orders >=> FAIL: Verify the 'Summary' column is not sortable >7. Apply this patches >8. Restart Plack >9. Reload the page >=> SUCCESS: Can sort by the summary column >10. Sign off :-D > >Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> > >Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> > >Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >--- > koha-tmpl/intranet-tmpl/prog/en/modules/acqui/parcel.tt | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/parcel.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/parcel.tt >index 09b7238793f..02ef881c06b 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/parcel.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/parcel.tt >@@ -437,7 +437,7 @@ > } > }, > { >- [% SET summary_fields = "biblio.author:biblio.title:biblio.isbn:biblio.publisher:me.internal_note:me.vendor_note" %] >+ [% SET summary_fields = "biblio.title:biblio.author:biblio.isbn:biblio.publisher:me.internal_note:me.vendor_note" %] > [% IF Koha.Preference('marcflavour')=='UNIMARC' %][% SET summary_fields = summary_fields _ ":biblio.ean" %][% END %] > "data": "[% summary_fields | html %]", > "render": function(data, type, row, meta) { >@@ -514,7 +514,7 @@ > > return result; > }, >- "orderable": false, >+ "orderable": true, > }, > { > "data": "", >-- >2.25.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 29570
:
130122
|
130123
|
130124
|
130125
|
130126
|
130127
|
130308
|
130309
| 130310 |
130311
|
130336