Attachment 130311 Details for Bug 29570 – Bug 29570: Simplify for loop

[patch] Bug 29570: Simplify for loop

Bug-29570-Simplify-for-loop.patch (text/plain), 1.19 KB, created by Jonathan Druart on 2022-02-08 16:36:10 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Jonathan Druart

Created: 2022-02-08 16:36:10 UTC

Size: 1.19 KB

patch

obsolete

>From f89baea0626d00511ead2f7b126c93ddd4e55b27 Mon Sep 17 00:00:00 2001
>From: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
>Date: Tue, 8 Feb 2022 17:35:27 +0100
>Subject: [PATCH] Bug 29570: Simplify for loop
>
>Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
>---
> Koha/REST/V1/Acquisitions/Orders.pm | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
>diff --git a/Koha/REST/V1/Acquisitions/Orders.pm b/Koha/REST/V1/Acquisitions/Orders.pm
>index 03851a6d96b..f46f4cfd7f4 100644
>--- a/Koha/REST/V1/Acquisitions/Orders.pm
>+++ b/Koha/REST/V1/Acquisitions/Orders.pm
>@@ -77,9 +77,9 @@ sub list {
> 
>         if ( exists $reserved_params->{_order_by} ) {
>             # _order_by passed, fix if required
>-            for ( my $i = 0; $i < scalar @{$reserved_params->{_order_by}}; $i++ ) {
>-                $reserved_params->{_order_by}->[$i] =~ s|biblio\.|biblio\.biblioitem\.|g
>-                    if $reserved_params->{_order_by}->[$i] =~ m/.*(isbn|ean|publisher).*/;
>+            for my $p ( @{$reserved_params->{_order_by}} ) {
>+                $p =~ s|biblio\.|biblio\.biblioitem\.|g
>+                    if $p =~ m/.*(isbn|ean|publisher).*/;
>             }
>         }
> 
>-- 
>2.25.1

Actions: View | Diff | Splinter Review

Attachments on bug 29570: 130122 | 130123 | 130124 | 130125 | 130126 | 130127 | 130308 | 130309 | 130310 | 130311 | 130336