Bugzilla – Attachment 130417 Details for
Bug 29684
Warning File not found: js/locale_data.js
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 29684: (QA follow-up) paycollect.pl don't needs borrower_data at all
Bug-29684-QA-follow-up-paycollectpl-dont-needs-bor.patch (text/plain), 3.02 KB, created by
Andrii Nugged
on 2022-02-09 23:22:21 UTC
(
hide
)
Description:
Bug 29684: (QA follow-up) paycollect.pl don't needs borrower_data at all
Filename:
MIME Type:
Creator:
Andrii Nugged
Created:
2022-02-09 23:22:21 UTC
Size:
3.02 KB
patch
obsolete
>From 0a38adee95609901556e2910345a6ac6415242d7 Mon Sep 17 00:00:00 2001 >From: Andrew Nugged <nugged@gmail.com> >Date: Thu, 10 Feb 2022 01:16:23 +0200 >Subject: [PATCH] Bug 29684: (QA follow-up) paycollect.pl don't needs > borrower_data at all > >--- > koha-tmpl/intranet-tmpl/prog/en/modules/members/paycollect.tt | 4 ++-- > members/paycollect.pl | 3 --- > 2 files changed, 2 insertions(+), 5 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/members/paycollect.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/members/paycollect.tt >index a7518f86a8..d2246e4a1a 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/members/paycollect.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/members/paycollect.tt >@@ -124,7 +124,7 @@ > <input type="hidden" name="amount" id="amount" value="[% amount | html %]" /> > <input type="hidden" name="amountoutstanding" id="amountoutstanding" value="[% amountoutstanding | html %]" /> > <input type="hidden" name="accountlines_id" id="accountlines_id" value="[% accountlines_id | html %]" /> >- <input type="hidden" name="title" id="title" value="[% borrower_data.title | html %]" /> >+ <input type="hidden" name="title" id="title" value="[% patron.title | html %]" /> > <input type="hidden" name="change_given" id="change_given" /> > > <fieldset class="rows"> >@@ -203,7 +203,7 @@ > <input type="hidden" name="debit_type_code" id="debit_type_code" value="[% debit_type_code | html %]" /> > <input type="hidden" name="amount" id="amount" value="[% amount | html %]" /> > <input type="hidden" name="accountlines_id" id="accountlines_id" value="[% accountlines_id | html %]" /> >- <input type="hidden" name="title" id="title" value="[% borrower_data.title | html %]" /> >+ <input type="hidden" name="title" id="title" value="[% patron.title | html %]" /> > <input type="hidden" name="payment_note" id="payment_note" value="[% payment_note | html %]" /> > <input type="hidden" name="amountoutstanding" id="amountoutstanding" value="[% amountoutstanding | html %]" /> > <input type="hidden" name="confirm_writeoff" id="confirm_writeoff" value="1" /> >diff --git a/members/paycollect.pl b/members/paycollect.pl >index 478602328e..1b57f9a6fc 100755 >--- a/members/paycollect.pl >+++ b/members/paycollect.pl >@@ -57,7 +57,6 @@ my $logged_in_user = Koha::Patrons->find( $loggedinuser ); > my $patron = Koha::Patrons->find( $borrowernumber ); > output_and_exit_if_error( $input, $cookie, $template, { module => 'members', logged_in_user => $logged_in_user, current_patron => $patron } ); > >-my $borrower = $patron->unblessed; > my $account = $patron->account; > my $category = $patron->category; > my $user = $input->remote_user; >@@ -239,8 +238,6 @@ if ( $total_paid and $total_paid ne '0.00' ) { > $total_paid = '0.00'; #TODO not right with pay_individual > } > >-$template->param(borrower_data => $borrower); >- > if ( $input->param('error_over') ) { > $template->param( error_over => 1, total_due => scalar $input->param('amountoutstanding') ); > } >-- >2.35.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 29684
:
128571
|
128675
|
129532
|
129534
|
129536
|
130184
|
130185
|
130186
|
130210
|
130211
|
130212
|
130413
|
130417
|
130421
|
130477
|
131510
|
131511
|
131512
|
131513
|
131514
|
131515