Bugzilla – Attachment 130433 Details for
Bug 24295
C4::Circulation::GetTransfers should be removed, use Koha::Item->get_transfer instead
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 24295: Remove GetTransfers from opac-basket.pl
Bug-24295-Remove-GetTransfers-from-opac-basketpl.patch (text/plain), 2.03 KB, created by
Martin Renvoize (ashimema)
on 2022-02-10 12:01:06 UTC
(
hide
)
Description:
Bug 24295: Remove GetTransfers from opac-basket.pl
Filename:
MIME Type:
Creator:
Martin Renvoize (ashimema)
Created:
2022-02-10 12:01:06 UTC
Size:
2.03 KB
patch
obsolete
>From 1d66da8b07d0288528117a6cb4bc748a239613dc Mon Sep 17 00:00:00 2001 >From: Martin Renvoize <martin.renvoize@ptfs-europe.com> >Date: Mon, 15 Mar 2021 16:09:42 +0000 >Subject: [PATCH] Bug 24295: Remove GetTransfers from opac-basket.pl > >This patch replaces the call to GetTransfers in opac-basket with the >get_transfer method available from the Koha::Item object > >Test plan >1/ Trigger the transfer of the item >2/ Check the opac-basket page for the display of the current transfer > status >3/ Apply patch >4/ Repeat step 2 >--- > opac/opac-basket.pl | 13 +++++++------ > 1 file changed, 7 insertions(+), 6 deletions(-) > >diff --git a/opac/opac-basket.pl b/opac/opac-basket.pl >index 4304541013..a254433d7e 100755 >--- a/opac/opac-basket.pl >+++ b/opac/opac-basket.pl >@@ -28,9 +28,9 @@ use C4::Biblio qw( > GetMarcUrls > ); > use C4::Items qw( GetHiddenItemnumbers GetItemsInfo ); >-use C4::Circulation qw( GetTransfers ); > use C4::Auth qw( get_template_and_user ); > use C4::Output qw( output_html_with_http_headers ); >+use Koha::DateUtils qw( output_pref ); > use Koha::RecordProcessor; > use Koha::CsvProfiles; > use Koha::AuthorisedValues; >@@ -142,11 +142,12 @@ foreach my $biblionumber ( @bibs ) { > if ($itm->{'location'}){ > $itm->{'location_opac'} = $shelflocations->{$itm->{'location'} }; > } >- my ( $transfertwhen, $transfertfrom, $transfertto ) = GetTransfers($itm->{itemnumber}); >- if ( defined( $transfertwhen ) && $transfertwhen ne '' ) { >- $itm->{transfertwhen} = $transfertwhen; >- $itm->{transfertfrom} = $transfertfrom; >- $itm->{transfertto} = $transfertto; >+ my $item_object = Koha::Items->find($itm->{itemnumber}); >+ my $transfer = $item_object->get_transfer; >+ if ( $transfer && $transfer->in_transit ) { >+ $itm->{transfertwhen} = output_pref({ dt => dt_from_string($transfer->datesent), dateonly => 1 }); >+ $itm->{transfertfrom} = $transfer->frombranch; >+ $itm->{transfertto} = $transfer->tobranch; > } > } > $num++; >-- >2.20.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 24295
:
118242
|
118243
|
118244
|
118245
|
118246
|
118247
|
118248
|
118249
|
118250
|
118287
|
118295
|
118296
|
118297
|
118298
|
118299
|
118300
|
118301
|
118302
|
118303
|
118304
|
118305
|
118306
|
118307
|
118308
|
118309
|
118310
|
119854
|
119855
|
119856
|
119857
|
119858
|
119859
|
119860
|
119861
|
119862
|
119863
|
119864
|
119866
|
119867
|
127465
|
127466
|
127467
|
127468
|
127469
|
127470
|
127471
|
127472
|
127473
|
127474
|
127475
|
127476
|
127477
|
130430
|
130431
|
130432
|
130433
|
130434
|
130435
|
130436
|
130437
|
130438
|
130439
|
130440
|
130441
|
130442
|
139546
|
139547
|
139548
|
139549
|
139550
|
139551
|
139552
|
139553
|
139554
|
139555
|
139556
|
139557
|
139558
|
139655
|
139656
|
139657
|
139658
|
139659
|
139660
|
139661
|
139662
|
139663
|
139664
|
139665
|
139666
|
139667