Bugzilla – Attachment 130510 Details for
Bug 30082
Bibliographic details tab missing when user can't add local cover image
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 30082: Bibliographic details tab missing when user can't add local cover image
Bug-30082-Bibliographic-details-tab-missing-when-u.patch (text/plain), 2.39 KB, created by
Owen Leonard
on 2022-02-11 15:31:13 UTC
(
hide
)
Description:
Bug 30082: Bibliographic details tab missing when user can't add local cover image
Filename:
MIME Type:
Creator:
Owen Leonard
Created:
2022-02-11 15:31:13 UTC
Size:
2.39 KB
patch
obsolete
>From ba315195bd93f07d78ea5d9b09847b9370ff64f3 Mon Sep 17 00:00:00 2001 >From: Owen Leonard <oleonard@myacpl.org> >Date: Fri, 11 Feb 2022 15:24:43 +0000 >Subject: [PATCH] Bug 30082: Bibliographic details tab missing when user can't > add local cover image > >This patch corrects the template logic which determines whether the >"Images" tab should be displayed on the bibliographic detail page. The >"Images" tab should display whenever local cover images are enabled, not >just if the user has permission to manage cover images. > >To test, apply the patch and go to Administration -> System preferences. > >- Enable the LocalCoverImages system preference. >- Locate and view the detail page for a bibliographic record in the > catalog which doesn't have a local cover image attached. > > - If you are logged in as a user with upload_local_cover_images > permission you should see an "Images" tab with the message "No > images have been uploaded for this bibliographic record yet" and an > upload button. > - If you are logged in as a user without upload_local_cover_images > permission you should see an "Images" tab with just the "No > images..." message. >--- > .../intranet-tmpl/prog/en/modules/catalogue/detail.tt | 8 +++----- > 1 file changed, 3 insertions(+), 5 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt >index 3b56260668..70a22e7262 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt >@@ -275,11 +275,9 @@ > [% IF suggestions.count %]<li><a href="#suggestion_details">Suggestion details</a></li>[% END %] > [% IF ( FRBRizeEditions ) %][% IF ( XISBNS ) %]<li><a href="#editions">Editions</a></li>[% END %][% END %] > [% IF ( LocalCoverImages ) %] >- [% IF ( localimages.count || CAN_user_tools_upload_local_cover_images ) %] >- <li> >- <a href="#images">Images ([% localimages.count || 0 | html %])</a> >- </li> >- [% END %] >+ <li> >+ <a href="#images">Images ([% localimages.count || 0 | html %])</a> >+ </li> > [% END %] > [% IF HTML5MediaEnabled && HTML5MediaSets.size %]<li id="media_tab"><a href="#html5media">Play media</a></li>[% END %] > [% IF ( Koha.Preference('NovelistSelectStaffEnabled') && Koha.Preference('NovelistSelectStaffProfile') && Koha.Preference('NovelistSelectStaffView') == 'tab' ) %] >-- >2.20.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 30082
:
130506
|
130510
|
130530
|
130537