Attachment 130540 Details for Bug 30081 – Bug 30081: Use itemtype description instead of itemtype code

[patch] Bug 30081: Use itemtype description instead of itemtype code

Bug-30081-Use-itemtype-description-instead-of-item.patch (text/plain), 1.76 KB, created by Katrin Fischer on 2022-02-13 14:20:28 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Katrin Fischer

Created: 2022-02-13 14:20:28 UTC

Size: 1.76 KB

patch

obsolete

>From 5d14a480c4adfa656ce7775618cdfcd85bbc180c Mon Sep 17 00:00:00 2001
>From: Lari Taskula <lari.taskula@hypernova.fi>
>Date: Fri, 11 Feb 2022 13:07:40 +0000
>Subject: [PATCH] Bug 30081: Use itemtype description instead of itemtype code
>
>To test:
>1. Use same plan as previous patch, but observe full item type description
>   instead of item type code
>
>Signed-off-by: Owen Leonard <oleonard@myacpl.org>
>
>Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
>---
> koha-tmpl/intranet-tmpl/prog/js/holds.js | 2 +-
> svc/holds                                | 1 +
> 2 files changed, 2 insertions(+), 1 deletion(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/js/holds.js b/koha-tmpl/intranet-tmpl/prog/js/holds.js
>index 3136796cc8..44e110df43 100644
>--- a/koha-tmpl/intranet-tmpl/prog/js/holds.js
>+++ b/koha-tmpl/intranet-tmpl/prog/js/holds.js
>@@ -176,7 +176,7 @@ $(document).ready(function() {
>                         "mDataProp": function( oObj ) {
>                             var data = "";
>                             if ( oObj.itemtype ) {
>-                                data += oObj.itemtype;
>+                                data += oObj.itemtype_description;
>                             }
>                             return data;
>                         }
>diff --git a/svc/holds b/svc/holds
>index 77c260ff27..c02602c0ff 100755
>--- a/svc/holds
>+++ b/svc/holds
>@@ -135,6 +135,7 @@ while ( my $h = $holds_rs->next() ) {
>         $hold->{itemnumber}     = $item->itemnumber();
>         $hold->{barcode}        = $item->barcode();
>         $hold->{itemtype}       = $item->effective_itemtype();
>+        $hold->{itemtype_description} = $item->itemtype->description;
>         $hold->{enumchron}      = $item->enumchron();
>         $hold->{itemcallnumber} = $item->itemcallnumber() || q{};
> 
>-- 
>2.30.2

Actions: View | Diff | Splinter Review

Attachments on bug 30081: 130490 | 130492 | 130493 | 130494 | 130539 | 130540