Bugzilla – Attachment 130584 Details for
Bug 29962
Table of items on item edit page missing columns button
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 29962: (bug 27526 follow-up): Fix columns button on item list
Bug-29962-bug-27526-follow-up-Fix-columns-button-o.patch (text/plain), 2.28 KB, created by
Lucas Gass (lukeg)
on 2022-02-14 23:03:59 UTC
(
hide
)
Description:
Bug 29962: (bug 27526 follow-up): Fix columns button on item list
Filename:
MIME Type:
Creator:
Lucas Gass (lukeg)
Created:
2022-02-14 23:03:59 UTC
Size:
2.28 KB
patch
obsolete
>From 07d542cc221d58c1a4092f3a5f11a026a786f211 Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >Date: Fri, 28 Jan 2022 09:49:44 +0100 >Subject: [PATCH] Bug 29962: (bug 27526 follow-up): Fix columns button on item > list > >The "Columns" button on the item list view has been broken (hidden) by >bug 27526. >"column_name" was removed from the item_header_loop: >- if ( $kohafield && $kohafield =~ /items.(.+)/ ) { >- $header_value{column_name} = $1; >- } > >We can still access the attribute name using 'attribute' however. >The difference is that non-mapped subfield will have an "attribute", but >there is a net to prevent a crash in columns_settings.inc: > 12 var named_id = $( 'thead th[data-colname="' + this.columnname + '"]', selector ).index( selector + ' th' ); > 13 var used_id = dt_parameters.bKohaColumnsUseNames ? named_id : counter; > 14 if ( used_id == -1 ) return; > >We should simply pass attribute. > >Test plan: >Create a non-mapped subfield (952$k) >Edit an item, add a value for k >On the item table at the top of the edit form notice that the "Columns" >button is back and that it's working correctly. >Note that 'k' cannot be hidden (may be considered as a bug, but it's not >a regression). > >Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> >--- > .../intranet-tmpl/prog/en/modules/cataloguing/additem.tt | 6 +----- > 1 file changed, 1 insertion(+), 5 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/additem.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/additem.tt >index b6fb2317bb..825e4c1c3a 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/additem.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/additem.tt >@@ -72,11 +72,7 @@ > <tr> > <th class="NoSort"> </th> > [% FOREACH item_header IN item_header_loop %] >- [% IF item_header.column_name %] >- <th data-colname="[% item_header.column_name | html %]"> >- [% ELSE %] >- <th> >- [% END %] >+ <th data-colname="[% item_header.attribute | html %]"> > [% item_header.header_value | html %] > </th> > [% END %] >-- >2.20.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 29962
:
129919
|
130584
|
130877