Bugzilla – Attachment 130593 Details for
Bug 30104
Holds to pull is broken
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 30104: (bug 29844 follow-up): Fix holds to pull
Bug-30104-bug-29844-follow-up-Fix-holds-to-pull.patch (text/plain), 926 bytes, created by
Jonathan Druart
on 2022-02-15 07:47:11 UTC
(
hide
)
Description:
Bug 30104: (bug 29844 follow-up): Fix holds to pull
Filename:
MIME Type:
Creator:
Jonathan Druart
Created:
2022-02-15 07:47:11 UTC
Size:
926 bytes
patch
obsolete
>From 6daeb361620f6528fae6acb5bb046b63f381dbc0 Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >Date: Tue, 15 Feb 2022 08:45:42 +0100 >Subject: [PATCH] Bug 30104: (bug 29844 follow-up): Fix holds to pull > >There was an error when circ/pendingreserves.pl was hit: >The method Koha::Items->biblionumber is not covered by tests! >--- > circ/pendingreserves.pl | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/circ/pendingreserves.pl b/circ/pendingreserves.pl >index 8ca7245b3c9..12e7c193c07 100755 >--- a/circ/pendingreserves.pl >+++ b/circ/pendingreserves.pl >@@ -193,7 +193,7 @@ my $holds = Koha::Holds->search( > my @biblionumbers = $holds->get_column('biblionumber'); > > my $all_items; >-foreach my $item ( $holds->get_items_that_can_fill ) { >+foreach my $item ( $holds->get_items_that_can_fill->as_list ) { > push @{$all_items->{$item->biblionumber}}, $item; > } > >-- >2.25.1
<b>You cannot view the attachment while viewing its details because your browser does not support IFRAMEs. <a href="attachment.cgi?id=130593">View the attachment on a separate page</a>.</b>
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 30104
:
130593
|
130620
|
130660