Attachment 130620 Details for Bug 30104 – Bug 30104: (bug 29844 follow-up): Fix holds to pull

[patch] Bug 30104: (bug 29844 follow-up): Fix holds to pull

Bug-30104-bug-29844-follow-up-Fix-holds-to-pull.patch (text/plain), 980 bytes, created by Lucas Gass (lukeg) on 2022-02-15 14:57:24 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Lucas Gass (lukeg)

Created: 2022-02-15 14:57:24 UTC

Size: 980 bytes

patch

obsolete

>From 93e0ab5d30f9489bf067839e07613f64aa94dd5a Mon Sep 17 00:00:00 2001
>From: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
>Date: Tue, 15 Feb 2022 08:45:42 +0100
>Subject: [PATCH] Bug 30104: (bug 29844 follow-up): Fix holds to pull
>
>There was an error when circ/pendingreserves.pl was hit:
>The method Koha::Items->biblionumber is not covered by tests!
>
>Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
>---
> circ/pendingreserves.pl | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/circ/pendingreserves.pl b/circ/pendingreserves.pl
>index 8ca7245b3c..12e7c193c0 100755
>--- a/circ/pendingreserves.pl
>+++ b/circ/pendingreserves.pl
>@@ -193,7 +193,7 @@ my $holds = Koha::Holds->search(
> my @biblionumbers = $holds->get_column('biblionumber');
> 
> my $all_items;
>-foreach my $item ( $holds->get_items_that_can_fill ) {
>+foreach my $item ( $holds->get_items_that_can_fill->as_list ) {
>     push @{$all_items->{$item->biblionumber}}, $item;
> }
> 
>-- 
>2.20.1

Actions: View | Diff | Splinter Review

Attachments on bug 30104: 130593 | 130620 | 130660