Attachment 130639 Details for Bug 30115 – Bug 30115: Uninitialized value warning in C4/Output.pm

[patch] Bug 30115: Uninitialized value warning in C4/Output.pm

Bug-30115-Uninitialized-value-warning-in-C4Outputp.patch (text/plain), 1.32 KB, created by Blou on 2022-02-15 21:19:08 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Blou

Created: 2022-02-15 21:19:08 UTC

Size: 1.32 KB

patch

obsolete

>From 53276debbe0ad40f008e3aa88e2af52f8191717f Mon Sep 17 00:00:00 2001
>From: Blou <blou@inlibro.com>
>Date: Tue, 15 Feb 2022 16:18:15 -0500
>Subject: [PATCH] Bug 30115: Uninitialized value warning in C4/Output.pm
>
>Use of uninitialized value $url_suffix in concatenation (.) or string at GIT/C4/Output.pm line 180.
>Use of uninitialized value $url_suffix in concatenation (.) or string at GIT/C4/Output.pm line 197.
>Use of uninitialized value $url_suffix in concatenation (.) or string at GIT/C4/Output.pm line 211.
>
>This is in pagination_bar sub.  A lot of pages call it.  For me it happened with any Authority search (authorities/authorities-home.pl) producing multiple results.
>
>Simple fix is initializing the variable.
>---
> C4/Output.pm | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/C4/Output.pm b/C4/Output.pm
>index 09dc73d41d..e36ec30bdc 100644
>--- a/C4/Output.pm
>+++ b/C4/Output.pm
>@@ -99,7 +99,7 @@ sub pagination_bar {
> 	$base_url =~ s/$delim$//;		# remove trailing delim
> 
>     my $url = $base_url . (($base_url =~ m/$delim/ or $base_url =~ m/\?/) ? '&amp;' : '?' ) . $startfrom_name . '=';
>-    my $url_suffix;
>+    my $url_suffix = '';
>     while ( my ( $k, $v ) = each %$additional_parameters ) {
>         $url_suffix .= '&amp;' . URI::Escape::uri_escape_utf8($k) . '=' . URI::Escape::uri_escape_utf8($v);
>     }
>-- 
>2.25.1

Actions: View | Diff | Splinter Review

Attachments on bug 30115: 130639 | 130661 | 130817