Bugzilla – Attachment 130664 Details for
Bug 28782
Get rid of custom query param list creation for request.pl
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 28782: Fix cancel holds in bulk
Bug-28782-Fix-cancel-holds-in-bulk.patch (text/plain), 1.82 KB, created by
Owen Leonard
on 2022-02-16 12:38:35 UTC
(
hide
)
Description:
Bug 28782: Fix cancel holds in bulk
Filename:
MIME Type:
Creator:
Owen Leonard
Created:
2022-02-16 12:38:35 UTC
Size:
1.82 KB
patch
obsolete
>From fcd003eaa19ae81c5da23414f4455336245fe6a5 Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >Date: Fri, 28 Jan 2022 14:47:12 +0100 >Subject: [PATCH] Bug 28782: Fix cancel holds in bulk > >See also bug 29969. > >Signed-off-by: Owen Leonard <oleonard@myacpl.org> >--- > koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt | 7 ++----- > 1 file changed, 2 insertions(+), 5 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt >index e726462ab2..08dac8d2e3 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt >@@ -1491,11 +1491,8 @@ > $("#cancelModalConfirmBtn").on("click",function(e) { > let link; > if(cancel_link.data('bulk')) { >- [% IF biblionumbers %] >- link = `request.pl?biblionumbers=[% biblionumbers | url %]&action=cancelBulk&ids=${$('.holds_table .select_hold:checked').toArray().map(el => $(el).data('id')).join(',')}`; >- [% ELSE %] >- link = `request.pl?biblionumber=[% biblionumber | url %]&action=cancelBulk&ids=${$('.holds_table .select_hold:checked').toArray().map(el => $(el).data('id')).join(',')}`; >- [% END %] >+ [% SET data_url = 'biblionumber=' _ biblionumbers.join('&biblionumber=') %] >+ link = `request.pl?[% data_url %]&action=cancelBulk&ids=${$('.holds_table .select_hold:checked').toArray().map(el => $(el).data('id')).join(',')}`; > } else { > let borrowernumber = cancel_link.data('borrowernumber'); > let biblionumber = cancel_link.data('biblionumber'); >-- >2.20.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 28782
:
123286
|
123287
|
123313
|
124510
|
124521
|
127112
|
127208
|
127209
|
129939
|
129940
|
129941
|
129942
|
130663
|
130664
|
130868
|
130869
|
130870
|
130871
|
130872
|
130873
|
130894
|
130895
|
130938
|
130939
|
130940
|
130941
|
130942
|
130943
|
131349
|
131350
|
131351
|
131352
|
131353
|
131354