Attachment 130772 Details for Bug 28663 – Bug 28663: Prevent discounts against void lines

[patch] Bug 28663: Prevent discounts against void lines

Bug-28663-Prevent-discounts-against-void-lines.patch (text/plain), 2.47 KB, created by Michal Denar on 2022-02-17 21:40:07 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Michal Denar

Created: 2022-02-17 21:40:07 UTC

Size: 2.47 KB

patch

obsolete

>From 81d5203d2c6f871f1feb0a2d8ed2999c1849ac34 Mon Sep 17 00:00:00 2001
>From: Martin Renvoize <martin.renvoize@ptfs-europe.com>
>Date: Mon, 5 Jul 2021 19:37:57 +0100
>Subject: [PATCH] Bug 28663: Prevent discounts against void lines
>
>With the introduction of double entry accounting for VOID actions, we
>need to add an additional filter to the 'Apply discount' button appearance
>
>Test plan
>1/ Add a debt
>2/ Pay the debt
>3/ Void the payment
>4/ Confirm that with the patch applied the 'Apply discount' button does
>not appear on the 'Void' accountline.
>
>Signed-off-by: Michal Denar <black23@gmail.com>
>---
> koha-tmpl/intranet-tmpl/prog/en/modules/members/boraccount.tt | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/members/boraccount.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/members/boraccount.tt
>index 2fd9240414..53773ea218 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/members/boraccount.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/members/boraccount.tt
>@@ -133,7 +133,7 @@
>         [% IF CAN_user_updatecharges_refund && account.is_debit && ( account.amountoutstanding != account.amount ) && !(account.status == 'REFUNDED') && !(account.debit_type_code == 'PAYOUT') %]
>           <button type="button"  class="btn btn-default btn-xs refund-action" data-toggle="modal" data-target="#issueRefundModal" data-item="[%- PROCESS account_type_description account=account -%]" data-accountline="[% account.accountlines_id | html %]" data-amount="[% account.amount | $Price %]" data-amountoutstanding="[% account.amountoutstanding | $Price %]" data-member="[% account.borrowernumber | html %]"><i class="fa fa-money"></i> Issue refund</button>
>         [% END %]
>-        [% IF CAN_user_updatecharges_discount && account.is_debit && ( account.amountoutstanding == account.amount ) && !(account.debit_type_code == 'PAYOUT') %]
>+        [% IF CAN_user_updatecharges_discount && account.is_debit && ( account.amountoutstanding == account.amount ) && !(account.debit_type_code == 'PAYOUT') && !(account.debit_type_code == 'VOID') %]
>           <button type="button" data-toggle="modal" data-target="#applyDiscountModal" data-item="[%- PROCESS account_type_description account=account -%]" data-accountline="[% account.accountlines_id | html %]" data-amount="[% account.amount | $Price %]" data-amountoutstanding="[% account.amountoutstanding | $Price %]" class="btn btn-default btn-xs discount-action">Apply discount</button>
>         [% END %]
>       </td>
>-- 
>2.30.2

Actions: View | Diff | Splinter Review

Attachments on bug 28663: 122588 | 127519 | 127538 | 130772 | 130927