Attachment 130808 Details for Bug 30127 – Bug 30127: By default show pending suggestions tab

[patch] Bug 30127: By default show pending suggestions tab

Bug-30127-By-default-show-pending-suggestions-tab.patch (text/plain), 6.04 KB, created by Fridolin Somers on 2022-02-18 06:24:35 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Fridolin Somers

Created: 2022-02-18 06:24:35 UTC

Size: 6.04 KB

patch

obsolete

>From 537e8df8d1c6be30e67b8d009b4dfa386808d22c Mon Sep 17 00:00:00 2001
>From: Fridolin Somers <fridolin.somers@biblibre.com>
>Date: Thu, 17 Feb 2022 18:00:26 -1000
>Subject: [PATCH] Bug 30127: By default show pending suggestions tab
>
>Pending suggestions are the most important ones in links pointing to suggestions.
>This tab should be the default one, like did Bug 7875
>
>Changing order in perl code seems really difficult because it is a
>generic code using GetDistinctValues()
>
>Test plan :
>1) Create some suggetions, accept some of them
>2) In staff interface, click on 'More > Suggestions'
>=> You see pending tab selected
>3) In left menu, click on 'Suggestions' under 'Late orders'
>=> You see pending tab selected
>4) In left menu, use a filter, then click on '[clear]'
>=> You see pending tab selected
>5) Create a suggestion, click on 'cancel'
>=> You see pending tab selected
>6) Create a suggestion, click on 'Suggestions' in breadcrumbs
>=> You see pending tab selected
>7) Edit an existing suggestion, click on '<< Back to suggestions'
>=> You see pending tab selected
>---
> .../prog/en/includes/acquisitions-menu.inc           |  2 +-
> koha-tmpl/intranet-tmpl/prog/en/includes/header.inc  |  2 +-
> .../prog/en/modules/suggestion/suggestion.tt         | 12 ++++++------
> 3 files changed, 8 insertions(+), 8 deletions(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/acquisitions-menu.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/acquisitions-menu.inc
>index a83bc21d96..fd3f1a841f 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/includes/acquisitions-menu.inc
>+++ b/koha-tmpl/intranet-tmpl/prog/en/includes/acquisitions-menu.inc
>@@ -4,7 +4,7 @@
>         <ul>
>             <li><a href="/cgi-bin/koha/acqui/acqui-home.pl">Acquisitions home</a></li>
>             [% IF ( CAN_user_acquisition_order_receive ) %]<li><a href="/cgi-bin/koha/acqui/lateorders.pl">Late orders</a></li>[% END %]
>-            [% IF ( suggestion && CAN_user_suggestions_suggestions_manage ) %]<li><a href="/cgi-bin/koha/suggestion/suggestion.pl">Suggestions</a></li>[% END %]
>+            [% IF ( suggestion && CAN_user_suggestions_suggestions_manage ) %]<li><a href="/cgi-bin/koha/suggestion/suggestion.pl#ASKED">Suggestions</a></li>[% END %]
>             <li><a href="/cgi-bin/koha/acqui/invoices.pl">Invoices</a></li>
>             [% IF CAN_user_acquisition_edi_manage %]
>                 <li><a href="/cgi-bin/koha/acqui/edifactmsgs.pl">EDIFACT messages</a></li>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/header.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/header.inc
>index 754ac0d294..0f194a2459 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/includes/header.inc
>+++ b/koha-tmpl/intranet-tmpl/prog/en/includes/header.inc
>@@ -53,7 +53,7 @@
>                         <li><a href="/cgi-bin/koha/reports/reports-home.pl">Reports</a></li>
>                     [% END %]
>                     [% IF ( CAN_user_suggestions_suggestions_manage ) %]
>-                        <li><a href="/cgi-bin/koha/suggestion/suggestion.pl">Suggestions</a></li>
>+                        <li><a href="/cgi-bin/koha/suggestion/suggestion.pl#ASKED">Suggestions</a></li>
>                     [% END %]
>                     [% IF ( CAN_user_tools ) %]
>                         <li><a href="/cgi-bin/koha/tools/tools-home.pl">Tools</a></li>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/suggestion/suggestion.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/suggestion/suggestion.tt
>index 27ca89ba9e..f58b09f4ee 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/suggestion/suggestion.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/suggestion/suggestion.tt
>@@ -68,7 +68,7 @@
>             [% IF op == 'save' %]
>                 [% IF ( suggestionid ) %]
>                     <li>
>-                        <a href="/cgi-bin/koha/suggestion/suggestion.pl">Suggestions</a>
>+                        <a href="/cgi-bin/koha/suggestion/suggestion.pl#ASKED">Suggestions</a>
>                     </li>
>                     <li>
>                         <a href="#" aria-current="page">
>@@ -77,7 +77,7 @@
>                     </li>
>                 [% ELSE %]
>                     <li>
>-                        <a href="/cgi-bin/koha/suggestion/suggestion.pl">Suggestions</a>
>+                        <a href="/cgi-bin/koha/suggestion/suggestion.pl#ASKED">Suggestions</a>
>                     </li>
>                     <li>
>                         <a href="#" aria-current="page">
>@@ -87,7 +87,7 @@
>                 [% END %]
>             [% ELSIF ( op == 'show' ) %]
>                 <li>
>-                    <a href="/cgi-bin/koha/suggestion/suggestion.pl">Suggestions</a>
>+                    <a href="/cgi-bin/koha/suggestion/suggestion.pl#ASKED">Suggestions</a>
>                 </li>
>                 <li>
>                     <a href="#" aria-current="page">
>@@ -313,7 +313,7 @@
>                     </fieldset>
> 
>                     <fieldset class="action">
>-                        <a href="suggestion.pl">&lt;&lt; Back to suggestions</a>
>+                        <a href="suggestion.pl#ASKED">&lt;&lt; Back to suggestions</a>
>                     </fieldset>
> 
>                 </div> 
>@@ -650,7 +650,7 @@
>                         [% ELSE %]
>                             <input type="submit" value="Submit your suggestion" />
>                         [% END %]
>-                        <a class="cancel" href="suggestion.pl">Cancel</a>
>+                        <a class="cancel" href="suggestion.pl#ASKED">Cancel</a>
>                     [% END %]
>                 </fieldset> 
>             </form> 
>@@ -1013,7 +1013,7 @@
>                                 </ol>
>                             </fieldset> 
> 
>-                            <h4>Filter by: <a style="font-size:80%;font-weight:normal;" href="/cgi-bin/koha/suggestion/suggestion.pl">[clear]</a></h4>
>+                            <h4>Filter by: <a style="font-size:80%;font-weight:normal;" href="/cgi-bin/koha/suggestion/suggestion.pl#ASKED">[clear]</a></h4>
> 
>                             <div id="limits">
>                                 <fieldset class="brief">
>-- 
>2.35.1

Actions: View | Diff | Splinter Review

Attachments on bug 30127: 130808 | 134431 | 134478 | 134485 | 134714