Attachment 130863 Details for Bug 30089 – Bug 30089: (bug 29844 follow-up) Fix placing holds - OPAC

[patch] Bug 30089: (bug 29844 follow-up) Fix placing holds - OPAC

Bug-30089-bug-29844-follow-up-Fix-placing-holds---.patch (text/plain), 1.26 KB, created by Nick Clemens (kidclamp) on 2022-02-18 15:17:02 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Nick Clemens (kidclamp)

Created: 2022-02-18 15:17:02 UTC

Size: 1.26 KB

patch

obsolete

>From caa2fdef1f2ea408ec8174c73c3bf6631eb0b023 Mon Sep 17 00:00:00 2001
>From: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
>Date: Tue, 15 Feb 2022 08:42:49 +0100
>Subject: [PATCH] Bug 30089: (bug 29844 follow-up) Fix placing holds - OPAC
>
>The method Koha::AuthorisedValues->authorised_value is not covered by tests!
>
>Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
>
>Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
>---
> opac/opac-reserve.pl | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/opac/opac-reserve.pl b/opac/opac-reserve.pl
>index 7be38e2568..a998a5bb65 100755
>--- a/opac/opac-reserve.pl
>+++ b/opac/opac-reserve.pl
>@@ -460,7 +460,7 @@ foreach my $biblioNum (@biblionumbers) {
>         }
>     }
> 
>-    my @notforloan_avs = Koha::AuthorisedValues->search_by_koha_field({ kohafield => 'items.notforloan', frameworkcode => $frameworkcode });
>+    my @notforloan_avs = Koha::AuthorisedValues->search_by_koha_field({ kohafield => 'items.notforloan', frameworkcode => $frameworkcode })->as_list;
>     my $notforloan_label_of = { map { $_->authorised_value => $_->opac_description } @notforloan_avs };
> 
>     my $visible_items = { map { $_->itemnumber => $_ } $biblio->items->filter_by_visible_in_opac( { patron => $patron } )->as_list };
>-- 
>2.30.2

Actions: View | Diff | Splinter Review

Attachments on bug 30089: 130581 | 130583 | 130592 | 130659 | 130863