Attachment 130866 Details for Bug 29803 – Bug 29803: Prevent local cover image to be hidden if Coce is enabled

[patch] Bug 29803: Prevent local cover image to be hidden if Coce is enabled

Bug-29803-Prevent-local-cover-image-to-be-hidden-i.patch (text/plain), 1.53 KB, created by Nick Clemens (kidclamp) on 2022-02-18 15:52:39 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Nick Clemens (kidclamp)

Created: 2022-02-18 15:52:39 UTC

Size: 1.53 KB

patch

obsolete

>From 29412f3c2e509370a3963be377bd67931a27c24d Mon Sep 17 00:00:00 2001
>From: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
>Date: Mon, 10 Jan 2022 12:19:54 +0100
>Subject: [PATCH] Bug 29803: Prevent local cover image to be hidden if Coce is
> enabled
>
>If Coce is enabled by no image are returned by the service, then no
>other image will be displayed (actually un-hidden)
>
>The getURL is returning early if no image is returned by the service and
>the "done" flag is never set.
>
>Test plan:
>Add a local cover image to a bibliographic record (ktd biblionumber=14
>is good)
>Set CoceHost = http://coce.bywatersolutions.com
>Select all CoceProviders
>Enable OpacCoce
>
>=> If no image is returned by Coce then the local image should be
>displayed anyway
>
>Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
>
>Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
>---
> koha-tmpl/opac-tmpl/bootstrap/js/coce.js | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/koha-tmpl/opac-tmpl/bootstrap/js/coce.js b/koha-tmpl/opac-tmpl/bootstrap/js/coce.js
>index 607cb89921..090059ba92 100644
>--- a/koha-tmpl/opac-tmpl/bootstrap/js/coce.js
>+++ b/koha-tmpl/opac-tmpl/bootstrap/js/coce.js
>@@ -20,7 +20,7 @@ KOHA.coce = {
>             var id = $(this).attr("class"); // id=isbn
>             if (id !== '') { ids.push(id); }
>         });
>-        if (ids.length == 0) return;
>+        if (ids.length == 0) { this.done = 1; return; }
>         ids = ids.join(',');
>         var coceURL = host + '/cover?id=' + ids + '&provider=' + provider;
>         $.ajax({
>-- 
>2.30.2

Actions: View | Diff | Splinter Review

Attachments on bug 29803: 129247 | 129248 | 130579 | 130580 | 130866 | 130867