Attachment 130947 Details for Bug 29844 – Bug 29844: Fix opac-reserve

[patch] Bug 29844: Fix opac-reserve

Bug-29844-Fix-opac-reserve.patch (text/plain), 1.31 KB, created by Jonathan Druart on 2022-02-21 11:27:57 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Jonathan Druart

Created: 2022-02-21 11:27:57 UTC

Size: 1.31 KB

patch

obsolete

>From 747d0588baceec2f16c5c00d55753c7680066b40 Mon Sep 17 00:00:00 2001
>From: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
>Date: Mon, 21 Feb 2022 12:26:54 +0100
>Subject: [PATCH] Bug 29844: Fix opac-reserve
>
>The method Koha::AuthorisedValues->authorised_value is not covered by tests!
>
>Trace begun at /kohadevbox/koha/Koha/Objects.pm line 572
>Koha::Objects::AUTOLOAD('Koha::AuthorisedValues=HASH(0x5598ac65a780)') called at /kohadevbox/koha/opac/opac-reserve.pl line 464
>---
> opac/opac-reserve.pl | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/opac/opac-reserve.pl b/opac/opac-reserve.pl
>index 7be38e25680..a998a5bb659 100755
>--- a/opac/opac-reserve.pl
>+++ b/opac/opac-reserve.pl
>@@ -460,7 +460,7 @@ foreach my $biblioNum (@biblionumbers) {
>         }
>     }
> 
>-    my @notforloan_avs = Koha::AuthorisedValues->search_by_koha_field({ kohafield => 'items.notforloan', frameworkcode => $frameworkcode });
>+    my @notforloan_avs = Koha::AuthorisedValues->search_by_koha_field({ kohafield => 'items.notforloan', frameworkcode => $frameworkcode })->as_list;
>     my $notforloan_label_of = { map { $_->authorised_value => $_->opac_description } @notforloan_avs };
> 
>     my $visible_items = { map { $_->itemnumber => $_ } $biblio->items->filter_by_visible_in_opac( { patron => $patron } )->as_list };
>-- 
>2.25.1

Actions: View | Diff | Splinter Review

Attachments on bug 29844: 129285 | 129286 | 129287 | 129290 | 129291 | 129292 | 129293 | 129295 | 129996 | 129997 | 129998 | 129999 | 130098 | 130099 | 130100 | 130101 | 130129 | 130130 | 130131 | 130132 | 130133 | 130134 | 130135 | 130136 | 130137 | 130138 | 130139 | 130143 | 130145 | 130146 | 130481 | 130947 | 131032