Attachment 13098 Details for Bug 8973 – [SIGNED-OFF] Bug 8973: HTML and URL escape missing in OPAC templates

[patch] [SIGNED-OFF] Bug 8973: HTML and URL escape missing in OPAC templates

SIGNED-OFF-Bug-8973-HTML-and-URL-escape-missing-in.patch (text/plain), 3.67 KB, created by Owen Leonard on 2012-10-29 15:20:13 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Owen Leonard

Created: 2012-10-29 15:20:13 UTC

Size: 3.67 KB

patch

obsolete

>From 691f3ac4a4b397ca8c3058b051663b1b256e9056 Mon Sep 17 00:00:00 2001
>From: Fridolyn SOMERS <fridolyn.somers@biblibre.com>
>Date: Fri, 26 Oct 2012 10:50:58 +0200
>Subject: [PATCH] [SIGNED-OFF] Bug 8973: HTML and URL escape missing in OPAC
> templates
>Content-Type: text/plain; charset="utf-8"
>
>Signed-off-by: Owen Leonard <oleonard@myacpl.org>
>---
> koha-tmpl/opac-tmpl/prog/en/modules/opac-detail.tt |    2 +-
> koha-tmpl/opac-tmpl/prog/en/modules/opac-review.tt |    4 ++--
> .../opac-tmpl/prog/en/modules/opac-suggestions.tt  |    2 +-
> 3 files changed, 4 insertions(+), 4 deletions(-)
>
>diff --git a/koha-tmpl/opac-tmpl/prog/en/modules/opac-detail.tt b/koha-tmpl/opac-tmpl/prog/en/modules/opac-detail.tt
>index 3ecdc27..1d0523a 100644
>--- a/koha-tmpl/opac-tmpl/prog/en/modules/opac-detail.tt
>+++ b/koha-tmpl/opac-tmpl/prog/en/modules/opac-detail.tt
>@@ -1218,7 +1218,7 @@ YAHOO.util.Event.onContentReady("furtherm", function () {
>         <div><a id="twitter" href="http://twitter.com/share" title="Share on Twitter">Twitter</a></div>
>         <div><a id="linkedin" href="http://www.linkedin.com/shareArticle?mini=true&amp;url=[% current_url |url %]&amp;title=[% title |url %]" title="Share on LinkedIn">LinkedIn</a></div>
>         <div><a id="delicious" href="http://www.delicious.com/save?url=[% current_url |url %]&amp;title=[% title |url %]" title="Share on Delicious">Delicious</a></div>
>-        <div><a id="email" href="mailto:?subject=[% title %]&amp;body=[% title %] ([% current_url |url %])" title="Share by email">Email</a></div>
>+        <div><a id="email" href="mailto:?subject=[% title |url %]&amp;body=[% title |url %] ([% current_url |url %])" title="Share by email">Email</a></div>
>         <div><g:plusone size="small"></g:plusone></div>
>     </div>
> [% END %]
>diff --git a/koha-tmpl/opac-tmpl/prog/en/modules/opac-review.tt b/koha-tmpl/opac-tmpl/prog/en/modules/opac-review.tt
>index 6845f6b..5ab225d 100644
>--- a/koha-tmpl/opac-tmpl/prog/en/modules/opac-review.tt
>+++ b/koha-tmpl/opac-tmpl/prog/en/modules/opac-review.tt
>@@ -1,4 +1,4 @@
>-[% INCLUDE 'doc-head-open.inc' %][% LibraryNameTitle or "Koha online" %] catalog &rsaquo; Comments on [% title %]
>+[% INCLUDE 'doc-head-open.inc' %][% LibraryNameTitle or "Koha online" %] catalog &rsaquo; Comments on [% title |html %]
> [% INCLUDE 'doc-head-close.inc' %]
> <style type="text/css">
>   #custom-doc { width:37.08em;*width:36.16em;min-width:485px; margin:1em auto; text-align:left; }
>@@ -68,7 +68,7 @@
>     <input type="hidden" name="biblionumber" value="[% biblionumber | html%]" />
>     [% IF ( reviewid ) %]<input type="hidden" name="reviewid" value="[% reviewid | html%]" />[% END %]
> 	<fieldset class="brief">
>-	<legend>Comments on <i>[% title |html %] [% subtitle %]</i>[% IF ( author ) %]by [% author %][% END %]</legend>
>+	<legend>Comments on <i>[% title |html %] [% subtitle %]</i>[% IF ( author ) %]by [% author |html %][% END %]</legend>
>             <ol><li><textarea id="review" name="review" cols="60" rows="8">[% review %]</textarea></li></ol>
> 		</fieldset>
>     <p>Note: Your comment must be approved by a librarian. </p>
>diff --git a/koha-tmpl/opac-tmpl/prog/en/modules/opac-suggestions.tt b/koha-tmpl/opac-tmpl/prog/en/modules/opac-suggestions.tt
>index b0d5972..49c3f66 100644
>--- a/koha-tmpl/opac-tmpl/prog/en/modules/opac-suggestions.tt
>+++ b/koha-tmpl/opac-tmpl/prog/en/modules/opac-suggestions.tt
>@@ -152,7 +152,7 @@ $.tablesorter.addParser({
>                     Search for:
>                 </th>
>                 <td>
>-                    <input type="text" name="title" value="[% title %]" />
>+                    <input type="text" name="title" value="[% title |html %]" />
>                 </td>
>                 <th>
>                 Suggested by:
>-- 
>1.7.9.5

Actions: View | Diff | Splinter Review

Attachments on bug 8973: 13070 | 13098 | 13514