Bugzilla – Attachment 131000 Details for
Bug 26102
Javascript injection in intranet search
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 26102: [19.11] Prevent XSS when To.json is used: authorities/authorities.tt
Bug-26102-1911-Prevent-XSS-when-Tojson-is-used-aut.patch (text/plain), 1.72 KB, created by
Wainui Witika-Park
on 2022-02-22 00:41:41 UTC
(
hide
)
Description:
Bug 26102: [19.11] Prevent XSS when To.json is used: authorities/authorities.tt
Filename:
MIME Type:
Creator:
Wainui Witika-Park
Created:
2022-02-22 00:41:41 UTC
Size:
1.72 KB
patch
obsolete
>From b4dbedbcd43ba2a3a4d6d2922e274a3c2afa5496 Mon Sep 17 00:00:00 2001 >From: Owen Leonard <oleonard@myacpl.org> >Date: Tue, 11 Aug 2020 12:34:18 +0000 >Subject: [PATCH] Bug 26102: [19.11] Prevent XSS when To.json is used: > authorities/authorities.tt > >Check that mandatory tags and subfields are correctly required when >editing an authority record. > >Signed-off-by: Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> >--- > koha-tmpl/intranet-tmpl/prog/en/modules/authorities/authorities.tt | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/authorities/authorities.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/authorities/authorities.tt >index 29b373dd353..a5e668637e2 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/authorities/authorities.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/authorities/authorities.tt >@@ -1,5 +1,6 @@ > [% USE raw %] > [% USE Asset %] >+[% USE To %] > [% INCLUDE 'doc-head-open.inc' %] > <title>Koha › Authorities › [% IF ( authid ) %]Modify authority #[% authid | html %] ([% authtypetext | html %])[% ELSE %]Adding authority ([% authtypetext | html %])[% END %]</title> > [% INCLUDE 'doc-head-close.inc' %] >@@ -69,7 +70,7 @@ function AreMandatoriesNotOk(){ > [% FOREACH subfield_loo IN innerloo.subfield_loop %] > [% IF ( subfield_loo.mandatory ) %]mandatories.push("[% subfield_loo.id | html %]"); > tab.push("[% BIG_LOO.number | html %]"); >- label.push("[% subfield_loo.marc_lib | $raw |replace("'", "\'") |replace('"', '\"') |replace('\n', '\\n') |replace('\r', '\\r') %]"); >+ label.push("[% To.json(subfield_loo.marc_lib) | html %]"); > [% END %] > [% END %] > [% END %] >-- >2.11.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 26102
:
107579
|
108083
|
108084
|
108085
|
108086
|
108087
|
108088
|
108089
|
108090
|
119643
|
119644
|
119645
|
119646
|
119647
|
119648
|
119649
|
127669
|
127670
|
127671
|
127672
|
127673
|
127674
|
127675
|
128716
|
128717
|
128718
|
128719
|
128720
|
128721
|
128722
|
130931
|
130932
|
130933
|
130934
|
130935
|
130936
|
130999
| 131000 |
131001
|
131002
|
131003
|
131004