Bugzilla – Attachment 131030 Details for
Bug 30159
Fix display of validation of important fields when biblio cataloguing
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 30159: Fix Check() to validate both mandatory and important fields
Bug-30159-Fix-Check-to-validate-both-mandatory-and.patch (text/plain), 2.89 KB, created by
Aleisha Amohia
on 2022-02-22 22:41:55 UTC
(
hide
)
Description:
Bug 30159: Fix Check() to validate both mandatory and important fields
Filename:
MIME Type:
Creator:
Aleisha Amohia
Created:
2022-02-22 22:41:55 UTC
Size:
2.89 KB
patch
obsolete
>From c8711a3df263bb1a8e6f13a7f9aa20c2801513cf Mon Sep 17 00:00:00 2001 >From: Adam Styles <adam.styles@esa.edu.au> >Date: Tue, 22 Feb 2022 11:32:52 +1100 >Subject: [PATCH] Bug 30159: Fix Check() to validate both mandatory and > important fields > >This patch adds a check for both mandatory and important fields when >validating bibliographic records during cataloguing. > >To test: > >1. Go to Admin -> Biblio frameworks. View the MARC structure of your >default framework. >2. Search for tag 082. Edit the subfields for this tag. >3. Check the 'important' checkbox for subfield a and Save. >4. Go to add or edit a new biblio record under Cataloguing. >5. Ensure the 082$a field is empty and hit Save. >6. Notice the confirmation pop-up is an unreadable display of HTML. >7. Click Cancel on the pop-up box. >8. Apply the patch and refresh the editor page. >9. Ensure the 082$a field is empty and hit Save. >10. Notice the confirmation pop-up is more helpful this time. Click >Cancel on the pop-up box. >11. Notice the 082$a field is displayed at the top of the page as an >important field that is missing information. Use the 'go to field' link >and confirm this works as expected. >12. Leave 082$a empty and hit Save. >13. This time click OK on the confirmation pop-up. Confirm you are able >to save your record as normal. > >Sponsored-by: Education Services Australia SCIS >--- > .../intranet-tmpl/prog/en/modules/cataloguing/addbiblio.tt | 12 +++++++++--- > 1 file changed, 9 insertions(+), 3 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/addbiblio.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/addbiblio.tt >index 5325d6e91fe..b81b909eef8 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/addbiblio.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/addbiblio.tt >@@ -711,8 +711,12 @@ function PopupMARCFieldDoc(field) { > if( ! StrAlert ){ > var StrWarning = AreFieldsNotOk(false); > if (StrWarning){ >- StrWarning += "\n" + _("Are you sure you want to save?"); >- var r=confirm(StrWarning); >+ >+ // Check important fields >+ $("#check_errors").html( AreFieldsNotOk(false) ); >+ $('html, body').animate({ scrollTop: 0 }, 'fast'); >+ >+ var r=confirm("Important fields(s) are not filled. Are you sure you want to save?"); > if (! r){ > return false; > } >@@ -720,7 +724,9 @@ function PopupMARCFieldDoc(field) { > document.f.submit(); > return true; > } else { >- $("#check_errors").html( StrAlert ); >+ >+ // Call AreFieldsNotOk() twice to check both mandatory and important fields >+ $("#check_errors").html( AreFieldsNotOk() + AreFieldsNotOk(false) ); > $('html, body').animate({ scrollTop: 0 }, 'fast'); > Sticky.hcSticky('refresh'); > return false; >-- >2.11.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 30159
:
131029
|
131030
|
131034
|
131365
|
131411
|
131412
|
131413