Bugzilla – Attachment 131038 Details for
Bug 20689
Improve usability of Item search fields administration page
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 20689: Replace marc (sub)field pull downs with input fields on item search fields config
Bug-20689-Replace-marc-subfield-pull-downs-with-in.patch (text/plain), 3.69 KB, created by
Martin Renvoize (ashimema)
on 2022-02-23 14:49:50 UTC
(
hide
)
Description:
Bug 20689: Replace marc (sub)field pull downs with input fields on item search fields config
Filename:
MIME Type:
Creator:
Martin Renvoize (ashimema)
Created:
2022-02-23 14:49:50 UTC
Size:
3.69 KB
patch
obsolete
>From 08271f61257f7c6b90c9c571ccf984c782308582 Mon Sep 17 00:00:00 2001 >From: Katrin Fischer <katrin.fischer.83@web.de> >Date: Thu, 9 Aug 2018 22:51:43 +0000 >Subject: [PATCH] Bug 20689: Replace marc (sub)field pull downs with input > fields on item search fields config >MIME-Version: 1.0 >Content-Type: text/plain; charset=UTF-8 >Content-Transfer-Encoding: 8bit > >The pull down for marc subfields on the item search fields config page is >long and hard to use. It also doesn't include the commonly used >upper case letters for custom item subfields. > >Also hard to use with its 999 entries is the marc field list. It doesn't >allow for tags like 01e, which exist in our MARC21 default framework. > >To test: >- Go to Administration > Item search fields >- Add different mappings with and without subfields >- Verify the entered values are stored correctly >- Edit mappings >- Verify editing works and changes save correctly > >Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> >Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> > >Signed-off-by: Mark Tompsett <mtompset@hotmail.com> >Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> > >Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> >Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> >--- > .../admin-items-search-field-form.inc | 32 +++++++------------ > 1 file changed, 11 insertions(+), 21 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/admin-items-search-field-form.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/admin-items-search-field-form.inc >index aaeef9045c..7232766b1a 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/includes/admin-items-search-field-form.inc >+++ b/koha-tmpl/intranet-tmpl/prog/en/includes/admin-items-search-field-form.inc >@@ -21,31 +21,21 @@ > <span class="required">Required</span> > </li> > <li> >- <label for="tagfield" required="required">MARC field: </label> >- <select id="tagfield" name="tagfield" class="required" required="required"> >- [% FOREACH tagfield IN ['001'..'999'] %] >- [% IF field && field.tagfield == tagfield %] >- <option value="[% tagfield | html %]" selected="selected">[% tagfield | html %]</option> >- [% ELSE %] >- <option value="[% tagfield | html %]">[% tagfield | html %]</option> >- [% END %] >- [% END %] >- </select> >+ <label class="required" for="tagfield">MARC field: </label> >+ [% IF field && field.tagfield == tagfield %] >+ <input type="text" id="tagfield" name="tagfield" maxlength="3" size="3" class="required" required="required" value="[% tagfield | html %]" /> >+ [% ELSE %] >+ <input type="text" id="tagfield" name="tagfield" maxlenght="3" size="3" class="required" required="required" /> >+ [% END %] > <span class="required">Required</span> > </li> > <li> > <label for="tagsubfield">MARC subfield: </label> >- <select id="tagsubfield" name="tagsubfield"> >- [% codes = [''] %] >- [% codes = codes.merge([0..9], ['a'..'z']) %] >- [% FOREACH tagsubfield IN codes %] >- [% IF field && field.tagsubfield == tagsubfield %] >- <option value="[% tagsubfield | html %]" selected="selected">[% tagsubfield | html %]</option> >- [% ELSE %] >- <option value="[% tagsubfield | html %]">[% tagsubfield | html %]</option> >- [% END %] >- [% END %] >- </select> >+ [% IF field && field.tagsubfield == tagsubfield %] >+ <input type="text" id="tagsubfield" name="tagsubfield" maxlength="1" size="1" value="[% tagsubfield | html %]" /> >+ [% ELSE %] >+ <input type="text" id="tagsubfield" name="tagsubfield" maxlength="1" size="1" /> >+ [% END %] > </li> > <li> > <label for="authorised_values_category">Authorised values category: </label> >-- >2.20.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 20689
:
77640
|
79554
|
79779
|
80538
|
80539
|
80712
|
80713
|
81137
|
81150
|
81151
|
83795
|
83796
|
83827
|
87955
|
87956
|
87957
|
88294
|
124056
|
124057
|
124058
|
124059
| 131038 |
131039
|
131040
|
131041