Attachment 131057 Details for Bug 22321 – Bug 22321: Allow managing the borrowernumber tied to ILL request

[patch] Bug 22321: Allow managing the borrowernumber tied to ILL request

Bug-22321-Allow-managing-the-borrowernumber-tied-t.patch (text/plain), 3.13 KB, created by Magnus Enger on 2022-02-24 08:58:07 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Magnus Enger

Created: 2022-02-24 08:58:07 UTC

Size: 3.13 KB

patch

obsolete

>From d041ea043f7d1c53dc9fc723c78b5182566494e6 Mon Sep 17 00:00:00 2001
>From: Lari Taskula <lari.taskula@hypernova.fi>
>Date: Mon, 14 Feb 2022 11:21:11 +0000
>Subject: [PATCH] Bug 22321: Allow managing the borrowernumber tied to ILL
> request
>
>Sometimes an ILL request is connected to the wrong borrower, and it
>would be nice to be able to connect it to the right one.
>
>In Swedish ILL the cardnumber of the patron connected with an ILL
>request is entered into the central Libris system and then propagated
>to Koha through the Libris API. This can lead to errors, and we have
>created a dummy "ILL patron" to catch these. It would then be good
>to be able to connect the ILL to the right patron in Koha.
>
>This commit makes it possible to edit illrequests.borrowernumber.
>
>To test:
>1. Apply patch
>2. Create two patrons, A and B
>3. Create a new ILL request for patron A
>4. Add a hold for patron A where biblionumber is the biblio tied
>   to this ILL request
>5. Go to
>cgi-bin/koha/ill/ill-requests.pl?method=edit_action&illrequest_id=161
>6. Observe Patron ID is editable
>7. Change borrowernumber to patron B's borrowernumber
>8. Click save
>9. Observe ILL request is now for patron B
>10. Go to patron B's details at
>cgi-bin/koha/members/moremember.pl?borrowernumber=B_borrowernumber
>11. At the bottom section of the page, click 1 Hold(s)
>12. Observe the hold you placed at step 4 has transferred to
>    patron b
>
>Signed-off-by: Magnus Enger <magnus@libriotech.no>
>---
> koha-tmpl/intranet-tmpl/prog/en/modules/ill/ill-requests.tt | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/ill/ill-requests.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/ill/ill-requests.tt
>index 5029e5f858..ca0cd43dc5 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/ill/ill-requests.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/ill/ill-requests.tt
>@@ -395,7 +395,7 @@
>                                 [% type = request.get_type %]
>                                 <li class="borrowernumber">
>                                     <label for="borrowernumber">Patron ID:</label>
>-                                    [% request.borrowernumber | html %]
>+                                    <input name="borrowernumber" id="borrowernumber" type="text" value="[% request.borrowernumber | html %]">
>                                 </li>
>                                 <li class="biblio_id">
>                                     <label for="biblio_id" class="biblio_id">Bibliographic record ID:</label>
>@@ -464,7 +464,6 @@
>                             <input type="hidden" value="edit_action" name="method">
>                             <input type="hidden" value="form" name="stage">
>                             <input type="hidden" value="[% request.illrequest_id | html %]" name="illrequest_id">
>-                            <input type="hidden" value="[% request.borrowernumber | html %]" name="borrowernumber">
>                             <input type="submit" value="Submit">
>                             <a class="cancel" href="/cgi-bin/koha/ill/ill-requests.pl?method=illview&amp;illrequest_id=[% request.id | html %]">Cancel</a>
>                         </fieldset>
>-- 
>2.11.0

Actions: View | Diff | Splinter Review

Attachments on bug 22321: 130544 | 130545 | 130546 | 131012 | 131013 | 131055 | 131056 | 131057 | 131058 | 131059 | 138873 | 138874 | 138875 | 138876 | 138877 | 138878 | 141342 | 141343 | 141344 | 141345 | 141346 | 141347