Attachment 131122 Details for Bug 29687 – Bug 29687: Uninitialized warning C4/XSLT line 286

[patch] Bug 29687: Uninitialized warning C4/XSLT line 286

Bug-29687-Uninitialized-warning-C4XSLT-line-286.patch (text/plain), 995 bytes, created by Nick Clemens (kidclamp) on 2022-02-25 14:01:49 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Nick Clemens (kidclamp)

Created: 2022-02-25 14:01:49 UTC

Size: 995 bytes

patch

obsolete

>From 55cdb9cfb34944e2328a32b302c5b3697959b359 Mon Sep 17 00:00:00 2001
>From: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
>Date: Mon, 13 Dec 2021 13:23:57 +0000
>Subject: [PATCH] Bug 29687: Uninitialized warning C4/XSLT line 286
>
>From plack-opac-error.log:
>[WARN] Use of uninitialized value $value in concatenation (.) or string at /usr/share/koha/C4/XSLT.pm line 286.
>
>Test plan:
>An opac search triggered the warning. So repeat it without warns.
>
>Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
>
>Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
>---
> C4/XSLT.pm | 1 +
> 1 file changed, 1 insertion(+)
>
>diff --git a/C4/XSLT.pm b/C4/XSLT.pm
>index 744389638c..fd4a3f41c0 100644
>--- a/C4/XSLT.pm
>+++ b/C4/XSLT.pm
>@@ -286,6 +286,7 @@ sub XSLTParse4Display {
> 
>     my $varxml = "<variables>\n";
>     while (my ($key, $value) = each %$variables) {
>+        $value //= q{};
>         $varxml .= "<variable name=\"$key\">$value</variable>\n";
>     }
>     $varxml .= "</variables>\n";
>-- 
>2.30.2

Actions: View | Diff | Splinter Review

Attachments on bug 29687: 128460 | 131122