Bugzilla – Attachment 131200 Details for
Bug 17648
ACCTDETAILS notice doesn't show in the notices tab in staff
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 17648: (QA follow-up) Further code cleaning
Bug-17648-QA-follow-up-Further-code-cleaning.patch (text/plain), 2.06 KB, created by
Martin Renvoize (ashimema)
on 2022-03-01 16:30:15 UTC
(
hide
)
Description:
Bug 17648: (QA follow-up) Further code cleaning
Filename:
MIME Type:
Creator:
Martin Renvoize (ashimema)
Created:
2022-03-01 16:30:15 UTC
Size:
2.06 KB
patch
obsolete
>From fc25392f8153168b1b98e78dbe39b9c289c32df5 Mon Sep 17 00:00:00 2001 >From: Martin Renvoize <martin.renvoize@ptfs-europe.com> >Date: Tue, 1 Mar 2022 16:24:55 +0000 >Subject: [PATCH] Bug 17648: (QA follow-up) Further code cleaning > >We actually have a Koha::Patron method to do all the work of finding the >right patron primary email address for notices.. we can use that here >instead of doing it long hand. >--- > members/memberentry.pl | 17 +---------------- > 1 file changed, 1 insertion(+), 16 deletions(-) > >diff --git a/members/memberentry.pl b/members/memberentry.pl >index 06adaab2b0..04beeb8fea 100755 >--- a/members/memberentry.pl >+++ b/members/memberentry.pl >@@ -462,24 +462,9 @@ if ((!$nok) and $nodouble and ($op eq 'insert' or $op eq 'save')){ > # If 'AutoEmailOpacUser' syspref is on, email user their account details from the 'notice' that matches the user's branchcode. > if ( C4::Context->preference("AutoEmailOpacUser") ) { > #look for defined primary email address, if blank - attempt to use borr.email and borr.emailpro instead >- my $emailaddr; >- if (C4::Context->preference("AutoEmailPrimaryAddress") ne 'OFF' && >- $newdata{C4::Context->preference("AutoEmailPrimaryAddress")} =~ /\w\@\w/ ) { >- $emailaddr = $newdata{C4::Context->preference("AutoEmailPrimaryAddress")} >- } >- elsif ($newdata{email} =~ /\w\@\w/) { >- $emailaddr = $newdata{email} >- } >- elsif ($newdata{emailpro} =~ /\w\@\w/) { >- $emailaddr = $newdata{emailpro} >- } >- elsif ($newdata{B_email} =~ /\w\@\w/) { >- $emailaddr = $newdata{B_email} >- } >+ my $emailaddr = $patron->notice_email_address; > # if we manage to find a valid email address, send notice > if ($emailaddr) { >- $newdata{emailaddr} = $emailaddr; >- my $err; > eval { > my $letter = GetPreparedLetter( > module => 'members', >-- >2.20.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 17648
:
131165
|
131199
|
131200
|
131202
|
131245
|
131403
|
131404
|
131405