Attachment 131201 Details for Bug 30205 – Bug 30205: Add subtitle to subscription detail page

[patch] Bug 30205: Add subtitle to subscription detail page

Bug-30205-Add-subtitle-to-subscription-detail-page.patch (text/plain), 3.39 KB, created by Lucas Gass (lukeg) on 2022-03-01 16:32:53 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Lucas Gass (lukeg)

Created: 2022-03-01 16:32:53 UTC

Size: 3.39 KB

patch

obsolete

>From 8d660fabaa162f18c6b88995c379c8d85f3c2359 Mon Sep 17 00:00:00 2001
>From: Lucas Gass <lucas@bywatersolutions.com>
>Date: Tue, 1 Mar 2022 16:30:04 +0000
>Subject: [PATCH] Bug 30205: Add subtitle to subscription detail page
>
>To test:
>1. Make some new serial subscriptions and connect them to biblios that contain subtitles.
>2. Do a serial search that will return your newly created subscription.
>3. Click on one of those subscription to be taken to the subscription detail page.
>4. Look at the main heading (h1) and the "Biblio:" line. Notice there is no subtitle in either place
>5. Apply patch, restart_all, and reload the subscription detail page.
>6. You should now see the subtitle on both the main heading (h1) and on the 'Biblio:' line.
>---
> C4/Serials.pm                                                 | 1 +
> .../prog/en/modules/serials/subscription-detail.tt            | 4 ++--
> 2 files changed, 3 insertions(+), 2 deletions(-)
>
>diff --git a/C4/Serials.pm b/C4/Serials.pm
>index 4a940f9a14..c464d25dc2 100644
>--- a/C4/Serials.pm
>+++ b/C4/Serials.pm
>@@ -269,6 +269,7 @@ sub GetSubscription {
>                 subscriptionhistory.*,
>                 aqbooksellers.name AS aqbooksellername,
>                 biblio.title AS bibliotitle,
>+                biblio.subtitle AS bibliosubtitle,
>                 subscription.biblionumber as bibnum
>        FROM subscription
>        LEFT JOIN subscriptionhistory ON subscription.subscriptionid=subscriptionhistory.subscriptionid
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/serials/subscription-detail.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/serials/subscription-detail.tt
>index 4cccfff7db..513addf3a1 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/serials/subscription-detail.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/serials/subscription-detail.tt
>@@ -50,7 +50,7 @@
>                 [% INCLUDE 'serials-toolbar.inc' %]
>                 [% INCLUDE 'mana/mana-comment-status.inc' %]
> 
>-                <h1>Subscription for [% bibliotitle | html %] [% IF closed %](closed)[% END %]</h1>
>+                <h1>Subscription for [% bibliotitle | html %] [% bibliosubtitle | html %] [% IF closed %](closed)[% END %]</h1>
> 
>                 [% IF ( abouttoexpire ) %]
>                     [% UNLESS closed %]
>@@ -111,7 +111,7 @@
>                                         <li><span class="label">Subscription ID: </span>[% subscriptionid | html %]</li>
>                                         <li><span class="label">Librarian identity:</span> [% librarian | html %]</li>
>                                         <li><span class="label">Vendor:</span> <a href="/cgi-bin/koha/acqui/supplier.pl?booksellerid=[% aqbooksellerid | uri %]">[% aqbooksellername | html %]</a></li>
>-                                        <li><span class="label">Biblio:</span>  <a href="/cgi-bin/koha/catalogue/[% default_bib_view | uri %].pl?biblionumber=[% bibnum | uri %]">[% bibliotitle | html %]</a> <em>([% bibnum | html %])</em></li>
>+                                        <li><span class="label">Biblio:</span>  <a href="/cgi-bin/koha/catalogue/[% default_bib_view | uri %].pl?biblionumber=[% bibnum | uri %]">[% bibliotitle | html %] [% bibliosubtitle | html %]</a> <em>([% bibnum | html %])</em></li>
>                                         [% IF ( OPACBaseURL ) %]
>                                             <li>
>                                                 <span class="label">OPAC view:</span>
>-- 
>2.20.1

Actions: View | Diff | Splinter Review

Attachments on bug 30205: 131201 | 131762 | 132915