Attachment 131205 Details for Bug 30207 – Bug 30207: Librarians with only "place_holds" permission can no longer update hold pickup locations

[patch] Bug 30207: Librarians with only "place_holds" permission can no longer update hold pickup locations

Bug-30207-Librarians-with-only-placeholds-permissi.patch (text/plain), 1.56 KB, created by ByWater Sandboxes on 2022-03-01 17:52:08 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: ByWater Sandboxes

Created: 2022-03-01 17:52:08 UTC

Size: 1.56 KB

patch

obsolete

>From ab71362cde66537f0aeacc99406156eb24667623 Mon Sep 17 00:00:00 2001
>From: Kyle Hall <kyle@bywatersolutions.com>
>Date: Tue, 1 Mar 2022 11:49:49 -0500
>Subject: [PATCH] Bug 30207: Librarians with only "place_holds" permission can
> no longer update hold pickup locations
>
>Bug 29540 increased the flags required to for modreserve.pl, but in doing so created a situation where a library can select a different pickup location for a hold, but upon clicking the "Update hold(s)" button, will be logged out due to having insufficient permissions for modreserve.pl.
>
>Test Plan:
>1) Create a librarian with "place_holds" permissions, but not "modify_holds_priority".
>2) Place a hold for a patron
>3) Attempt to change the pickup location from request.pl
>4) Note you get logged out with a permissions error
>5) Apply this patch
>6) Restart all the things!
>7) Attempt to change the pickup location from request.pl
>8) This time it should succeed!
>
>Signed-off-by: Christopher Brannon <cbrannon@cdalibrary.org>
>---
> reserve/modrequest.pl | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/reserve/modrequest.pl b/reserve/modrequest.pl
>index d95e82e815..76cb8a9d0d 100755
>--- a/reserve/modrequest.pl
>+++ b/reserve/modrequest.pl
>@@ -38,7 +38,7 @@ my ( $template, $loggedinuser, $cookie ) = get_template_and_user(
>         template_name   => "about.tt",
>         query           => $query,
>         type            => "intranet",
>-        flagsrequired   => { reserveforothers => 1 },
>+        flagsrequired   => { reserveforothers => [ 'place_holds', 'modify_holds_priority' ] },
>     }
> );
> 
>-- 
>2.30.2

Actions: View | Diff | Splinter Review

Attachments on bug 30207: 131203 | 131205 | 134808 | 134977 | 134978