Bugzilla – Attachment 131232 Details for
Bug 29857
We must stringify our exceptions correctly
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 29857: (QA follow-up) Fix unit test Object.t
Bug-29857-QA-follow-up-Fix-unit-test-Objectt.patch (text/plain), 1.28 KB, created by
Fridolin Somers
on 2022-03-02 07:06:09 UTC
(
hide
)
Description:
Bug 29857: (QA follow-up) Fix unit test Object.t
Filename:
MIME Type:
Creator:
Fridolin Somers
Created:
2022-03-02 07:06:09 UTC
Size:
1.28 KB
patch
obsolete
>From a96b00ca7e33991d81c53e964672d8d33f9f3ab4 Mon Sep 17 00:00:00 2001 >From: Fridolin Somers <fridolin.somers@biblibre.com> >Date: Tue, 1 Mar 2022 21:04:13 -1000 >Subject: [PATCH] Bug 29857: (QA follow-up) Fix unit test Object.t > >Unit test failling with : > # Failed test 'Exception message correct' > # at /kohadevbox/koha/t/db_dependent/Koha/Object.t line 335. > # got: 'Exception 'Koha::Exception' thrown 'Asked to embed items but its return value doesn't implement to_api' > # ' > # expected: 'Asked to embed items but its return value doesn't implement to_api' > # Looks like you failed 1 test of 29. > >Fixed by using $@->message like in other places. > >prove t/db_dependent/Koha/Object.t >--- > t/db_dependent/Koha/Object.t | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/t/db_dependent/Koha/Object.t b/t/db_dependent/Koha/Object.t >index f692c183ff..10c94c38e3 100755 >--- a/t/db_dependent/Koha/Object.t >+++ b/t/db_dependent/Koha/Object.t >@@ -333,7 +333,7 @@ subtest "to_api() tests" => sub { > "An exception is thrown if a blessed object to embed doesn't implement to_api"; > > is( >- "$@", >+ $@->message, > "Asked to embed items but its return value doesn't implement to_api", > "Exception message correct" > ); >-- >2.35.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 29857
:
129329
|
129330
|
130007
|
130008
|
130009
|
130010
|
130011
|
130012
|
130013
|
130014
|
130015
|
130156
|
130157
|
130158
|
130355
|
131112
|
131113
|
131114
|
131115
|
131116
|
131117
| 131232 |
131240
|
131241
|
131242
|
131243
|
131244
|
131256
|
131258
|
131287
|
131288
|
131289
|
131290
|
131291