Bugzilla – Attachment 131240 Details for
Bug 29857
We must stringify our exceptions correctly
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 29857: (follow-up) Fix Barcode_transform_hooks.t
Bug-29857-follow-up-Fix-Barcodetransformhookst.patch (text/plain), 1.57 KB, created by
Tomás Cohen Arazi (tcohen)
on 2022-03-02 12:29:01 UTC
(
hide
)
Description:
Bug 29857: (follow-up) Fix Barcode_transform_hooks.t
Filename:
MIME Type:
Creator:
Tomás Cohen Arazi (tcohen)
Created:
2022-03-02 12:29:01 UTC
Size:
1.57 KB
patch
obsolete
>From ea325f11dff5cdfdccf32fcd171991b41fa5a2f4 Mon Sep 17 00:00:00 2001 >From: Tomas Cohen Arazi <tomascohen@theke.io> >Date: Wed, 2 Mar 2022 09:28:35 -0300 >Subject: [PATCH] Bug 29857: (follow-up) Fix Barcode_transform_hooks.t > >Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> >--- > t/db_dependent/Koha/Plugins/Barcode_transform_hooks.t | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > >diff --git a/t/db_dependent/Koha/Plugins/Barcode_transform_hooks.t b/t/db_dependent/Koha/Plugins/Barcode_transform_hooks.t >index 2fba2fb744..ff990be9f1 100755 >--- a/t/db_dependent/Koha/Plugins/Barcode_transform_hooks.t >+++ b/t/db_dependent/Koha/Plugins/Barcode_transform_hooks.t >@@ -90,13 +90,13 @@ subtest 'patron_barcode_transform() and item_barcode_transform() hook tests' => > > my $item; > warning_like { $item = $builder->build_sample_item(); } >- qr/Plugin error \(Test Plugin\): item_barcode_transform called with parameter: /, >+ qr/Plugin error \(Test Plugin\): Exception 'Koha::Exception' thrown 'item_barcode_transform called with parameter: /, > 'Koha::Item->store calls the item_barcode_transform hook'; > > $item->barcode('THISISATEST'); > >- warning_is { $item->store(); } >- 'Plugin error (Test Plugin): item_barcode_transform called with parameter: THISISATEST', >+ warning_like { $item->store(); } >+ qr/Plugin error \(Test Plugin\): Exception 'Koha::Exception' thrown 'item_barcode_transform called with parameter: THISISATEST'/, > 'Koha::Item->store calls the item_barcode_transform hook'; > > $schema->storage->txn_rollback; >-- >2.35.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 29857
:
129329
|
129330
|
130007
|
130008
|
130009
|
130010
|
130011
|
130012
|
130013
|
130014
|
130015
|
130156
|
130157
|
130158
|
130355
|
131112
|
131113
|
131114
|
131115
|
131116
|
131117
|
131232
| 131240 |
131241
|
131242
|
131243
|
131244
|
131256
|
131258
|
131287
|
131288
|
131289
|
131290
|
131291