Bugzilla – Attachment 131332 Details for
Bug 29523
Add a way to prevent embedding objects that should not be allowed
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 29523: Cache the restricted branches list
Bug-29523-Cache-the-restricted-branches-list.patch (text/plain), 1.97 KB, created by
Martin Renvoize (ashimema)
on 2022-03-03 15:20:04 UTC
(
hide
)
Description:
Bug 29523: Cache the restricted branches list
Filename:
MIME Type:
Creator:
Martin Renvoize (ashimema)
Created:
2022-03-03 15:20:04 UTC
Size:
1.97 KB
patch
obsolete
>From c8db894fab66447254cc208bee232050be158c14 Mon Sep 17 00:00:00 2001 >From: Martin Renvoize <martin.renvoize@ptfs-europe.com> >Date: Thu, 3 Mar 2022 14:40:20 +0000 >Subject: [PATCH] Bug 29523: Cache the restricted branches list > >This patch introduces a very localised cache of the restricted branches >list in the logged in patron object. >--- > Koha/Patron.pm | 15 +++++++-------- > 1 file changed, 7 insertions(+), 8 deletions(-) > >diff --git a/Koha/Patron.pm b/Koha/Patron.pm >index 44352a72c6..6d13ff0556 100644 >--- a/Koha/Patron.pm >+++ b/Koha/Patron.pm >@@ -1431,13 +1431,8 @@ sub can_see_patrons_from { > $can = 1; > } elsif ( $self->has_permission( { borrowers => 'view_borrower_infos_from_any_libraries' } ) ) { > $can = 1; >- } elsif ( my $library_groups = $self->library->library_groups ) { >- while ( my $library_group = $library_groups->next ) { >- if ( $library_group->parent->has_child( $branchcode ) ) { >- $can = 1; >- last; >- } >- } >+ } elsif ( my @branches = $self->libraries_where_can_see_patrons ) { >+ $can = any { $_ eq $branchcode } @branches; > } > return $can; > } >@@ -1483,6 +1478,8 @@ An empty array means no restriction, the patron can see patron's infos from any > > sub libraries_where_can_see_patrons { > my ( $self ) = @_; >+ return $self->{_restricted_branchcodes} if exists($self->{_restricted_branchcodes}); >+ > my $userenv = C4::Context->userenv; > > return () unless $userenv; # For tests, but userenv should be defined in tests... >@@ -1516,7 +1513,9 @@ sub libraries_where_can_see_patrons { > @restricted_branchcodes = grep { defined $_ } @restricted_branchcodes; > @restricted_branchcodes = uniq(@restricted_branchcodes); > @restricted_branchcodes = sort(@restricted_branchcodes); >- return @restricted_branchcodes; >+ >+ $self->{_restricted_branchcodes} = @restricted_branchcodes; >+ return $self->{_restricted_branchcodes}; > } > > =head3 has_permission >-- >2.20.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 29523
:
127886
|
127887
|
127888
|
127889
|
127991
|
127992
|
127993
|
127994
|
128042
|
128043
|
128044
|
128045
|
128046
|
128047
|
128048
|
128688
|
128689
|
128690
|
128691
|
128692
|
128693
|
128694
|
131326
|
131331
|
131332
|
136684
|
136685
|
136686
|
136687
|
136688
|
136689
|
136690
|
136691
|
136692
|
136706
|
136714
|
148736
|
148737
|
148738
|
148739
|
148740
|
148741
|
148742
|
148743
|
148744
|
148745
|
150989
|
150990
|
150991
|
150992
|
150993
|
150994
|
150995
|
150996
|
150997
|
150998
|
156939
|
156940
|
156941
|
156942
|
156943
|
156944
|
156945
|
156946
|
156947
|
156948
|
156949
|
156965
|
157049
|
157071
|
157072
|
157073
|
157074
|
157075
|
157076
|
157077
|
157078
|
157079
|
157080
|
157081
|
157406
|
157407
|
157408
|
157409
|
157410
|
157411
|
157412
|
157413
|
157414
|
157415
|
157416
|
157673
|
157679
|
157683
|
157799
|
157881
|
157882
|
157883
|
157884
|
157885
|
157886
|
157887
|
157888
|
157889
|
157890
|
157891
|
157892
|
157893
|
158013