Attachment 131390 Details for Bug 30231 – Bug 30231: (bug 5927 follow-up) See (rejected) forms of series entry visible in search result (OPAC and intra)

[patch] Bug 30231: (bug 5927 follow-up) See (rejected) forms of series entry visible in search result (OPAC and intra)

0001-Bug-30231-bug-5927-follow-up-See-rejected-forms-of-s.patch (text/plain), 5.88 KB, created by Janusz Kaczmarek on 2022-03-04 22:34:39 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Janusz Kaczmarek

Created: 2022-03-04 22:34:39 UTC

Size: 5.88 KB

patch

obsolete

>From b9255d5d3ae64fdd9d6f59330e9e6363ae319a51 Mon Sep 17 00:00:00 2001
>From: Janusz Kaczmarek <januszop@gmail.com>
>Date: Fri, 4 Mar 2022 22:47:11 +0100
>Subject: [PATCH] Bug 30231: (bug 5927 follow-up) See (rejected) forms of
> series entry visible in search result (OPAC and intra)
>
>When using zebra with IncludeSeeFromInSearches on, with traced series, the rejected
>forms (4XX) of series entries are visible in result lists, both in OPAC and intra
>interfaces.
>
>Test plan:
>=========
>1. Have a MARC 21 installation with zebra, and with IncludeSeeFromInSearches on.
> Have an authority records for series (130, or 100/110/111 with
> title) with rejected forms (4XX fields). So the auth record should
> contain at least:
>
> 130 _0 $a Series title
> 430 _0 $a Some other title under which the series in known
>
> Use (each) authority record in at least two biblio records (in appropriate
> fields, i.e. 800/810/811/830 or even deprecated 440, if it makes use
> of UNIF_TITLE).
> Don't forget to properly input also 490 (for 8XX). So the biblio record
> shold contain at least:
>
> 245 nn $a Work title.
> 490 1_ $a Series title
> 830 _0 $a Series entry $9 <koha_id>
>
> Reindex.
>2. Perform a simple biblio search (in OPAC and in intra) with the title
> from auth record.
>3. You shold get a list of results. See the Series information--you
> shold see not only the accepted entry from 1XX in auth but also the
> rejected forms from 4XX.
>4. Apply the patch.
>5. Repeat 3. You shold see only the entry form of series now.
>---
> koha-tmpl/intranet-tmpl/prog/en/xslt/MARC21slimUtils.xsl | 6 +++---
> koha-tmpl/opac-tmpl/bootstrap/en/xslt/MARC21slimUtils.xsl | 6 +++---
> 2 files changed, 6 insertions(+), 6 deletions(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/xslt/MARC21slimUtils.xsl b/koha-tmpl/intranet-tmpl/prog/en/xslt/MARC21slimUtils.xsl
>index dfc9cc0186..6e8ed31529 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/xslt/MARC21slimUtils.xsl
>+++ b/koha-tmpl/intranet-tmpl/prog/en/xslt/MARC21slimUtils.xsl
>@@ -411,7 +411,7 @@
> <xsl:if test="marc:datafield[@tag=440 or @tag=490]">
> Series: 
> 
>- <xsl:for-each select="marc:datafield[@tag=440]">
>+ <xsl:for-each select="marc:datafield[@tag=440 and @ind1!='z']">
> <a><xsl:attribute name="href"><xsl:value-of select="$searchurl"/>?q=se,phr:"<xsl:value-of select="str:encode-uri(marc:subfield[@code='a'], true())"/>"</xsl:attribute>
> <xsl:call-template name="chopPunctuation">
> <xsl:with-param name="chopString">
>@@ -461,7 +461,7 @@
> </xsl:for-each>
> 
> <xsl:if test="marc:datafield[@tag=490][@ind1=1]">
>- <xsl:for-each select="marc:datafield[@tag=800 or @tag=810 or @tag=811]">
>+ <xsl:for-each select="marc:datafield[(@tag=800 or @tag=810 or @tag=811) and @ind1!='z']">
> <xsl:choose>
> <xsl:when test="$UseControlNumber = '1' and marc:subfield[@code='w']">
> <a><xsl:attribute name="href"><xsl:value-of select="$searchurl"/>?q=rcn:<xsl:value-of select="str:encode-uri(marc:subfield[@code='w'], true())"/></xsl:attribute>
>@@ -503,7 +503,7 @@
> <xsl:choose><xsl:when test="position()=last()"><xsl:text></xsl:text></xsl:when><xsl:otherwise> | </xsl:otherwise></xsl:choose>
> </xsl:for-each>
> 
>- <xsl:for-each select="marc:datafield[@tag=830]">
>+ <xsl:for-each select="marc:datafield[@tag=830 and @ind1!='z']">
> <xsl:choose>
> <xsl:when test="$UseControlNumber = '1' and marc:subfield[@code='w']">
> <a href="/cgi-bin/koha/catalogue/search.pl?q=rcn:{marc:subfield[@code='w']}">
>diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/xslt/MARC21slimUtils.xsl b/koha-tmpl/opac-tmpl/bootstrap/en/xslt/MARC21slimUtils.xsl
>index 105da508c7..156e99d657 100644
>--- a/koha-tmpl/opac-tmpl/bootstrap/en/xslt/MARC21slimUtils.xsl
>+++ b/koha-tmpl/opac-tmpl/bootstrap/en/xslt/MARC21slimUtils.xsl
>@@ -375,7 +375,7 @@
> <xsl:if test="marc:datafield[@tag=440 or @tag=490]">
> Series: 
> 
>- <xsl:for-each select="marc:datafield[@tag=440]">
>+ <xsl:for-each select="marc:datafield[@tag=440 and @ind1!='z']">
> <a><xsl:attribute name="href"><xsl:value-of select="$searchurl"/>?q=se,phr:"<xsl:value-of select="str:encode-uri(marc:subfield[@code='a'], true())"/>"</xsl:attribute>
> <xsl:call-template name="chopPunctuation">
> <xsl:with-param name="chopString">
>@@ -425,7 +425,7 @@
> </xsl:for-each>
> 
> <xsl:if test="marc:datafield[@tag=490][@ind1=1]">
>- <xsl:for-each select="marc:datafield[@tag=800 or @tag=810 or @tag=811]">
>+ <xsl:for-each select="marc:datafield[(@tag=800 or @tag=810 or @tag=811) and @ind1!='z']">
> <xsl:choose>
> <xsl:when test="$UseControlNumber = '1' and marc:subfield[@code='w']">
> <a><xsl:attribute name="href"><xsl:value-of select="$searchurl"/>?q=rcn:<xsl:value-of select="str:encode-uri(marc:subfield[@code='w'], true())"/></xsl:attribute>
>@@ -467,7 +467,7 @@
> <xsl:choose><xsl:when test="position()=last()"><xsl:text></xsl:text></xsl:when><xsl:otherwise> | </xsl:otherwise></xsl:choose>
> </xsl:for-each>
> 
>- <xsl:for-each select="marc:datafield[@tag=830]">
>+ <xsl:for-each select="marc:datafield[@tag=830 and @ind1!='z']">
> <xsl:choose>
> <xsl:when test="$UseControlNumber = '1' and marc:subfield[@code='w']">
> <a href="/cgi-bin/koha/catalogue/search.pl?q=rcn:{marc:subfield[@code='w']}">
>-- 
>2.30.2
>

Actions: View | Diff | Splinter Review

Attachments on bug 30231: 131390 | 136556 | 139482