Bugzilla – Attachment 131495 Details for
Bug 24001
Cannot edit card template
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 24001: Fix Card template/rpinter profile creation and edit
Bug-24001-Fix-Card-templaterpinter-profile-creatio.patch (text/plain), 1.79 KB, created by
The Minh Luong
on 2022-03-08 16:59:05 UTC
(
hide
)
Description:
Bug 24001: Fix Card template/rpinter profile creation and edit
Filename:
MIME Type:
Creator:
The Minh Luong
Created:
2022-03-08 16:59:05 UTC
Size:
1.79 KB
patch
obsolete
>From b808af4f57dada522569d170e5e374efad699a2d Mon Sep 17 00:00:00 2001 >From: Nick Clemens <nick@bywatersolutions.com> >Date: Fri, 4 Mar 2022 16:19:35 +0000 >Subject: [PATCH] Bug 24001: Fix Card template/rpinter profile creation and > edit >MIME-Version: 1.0 >Content-Type: text/plain; charset=UTF-8 >Content-Transfer-Encoding: 8bit > >This patch adjusts the template/profiles to use the default of '0' >This should probably be NULL, and the columns foreign keys, this code >could use a further rewrite, but this should fix a long standing bug > >To test: > 1 - Using the fresh install, with all the sample data. > 2 - Go to Home ⺠Tools ⺠Patron card creator ⺠Templates > 3 - New > Card template > 4 - Save > 5 - Error: DBD::mysql::st execute failed: Incorrect integer value: '' for column 'profile_id' at row 1 > 6 - Edit an existing template > 7 - Save > 8 - Error: Can't bless non-reference value at /kohadevbox/koha/C4/Creators/Profile.pm line 89 > 9 - Create a new 'Printer profile' >10 - Save >11 - Error: DBD::mysql::st execute failed: Incorrect integer value: '' for column 'template_id' at row 1 >12 - Apply the attached patch. >13 - Verify you can create a new 'Card template' and 'Printer profile' with no errors >14 - Verify you can edit and save both of the newly created objects above >--- > C4/Creators/Profile.pm | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/C4/Creators/Profile.pm b/C4/Creators/Profile.pm >index cd1de4038b..b9759bd6a8 100644 >--- a/C4/Creators/Profile.pm >+++ b/C4/Creators/Profile.pm >@@ -59,7 +59,7 @@ sub new { > my $type = ref($invocant) || $invocant; > my $self = { > printer_name => 'Default Printer', >- template_id => '', >+ template_id => 0, > paper_bin => 'Tray 1', > offset_horz => 0, > offset_vert => 0, >-- >2.25.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 24001
:
95981
|
98722
|
99164
|
106434
|
109764
|
131381
|
131494
|
131495
|
134074
|
134075
|
134077
|
134078
|
134080
|
134081
|
134124
|
134125
|
134346