Attachment 131525 Details for Bug 30243 – Bug 30243: When branccode is required on OPAC suggestion page default to empty value

[patch] Bug 30243: When branccode is required on OPAC suggestion page default to empty value

Bug-30243-When-branccode-is-required-on-OPAC-sugge.patch (text/plain), 1.78 KB, created by Lucas Gass (lukeg) on 2022-03-09 14:58:49 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Lucas Gass (lukeg)

Created: 2022-03-09 14:58:49 UTC

Size: 1.78 KB

patch

obsolete

>From bc5b34f7fea110e9c087ec422bf60c7291bc4776 Mon Sep 17 00:00:00 2001
>From: Lucas Gass <lucas@bywatersolutions.com>
>Date: Wed, 9 Mar 2022 14:55:21 +0000
>Subject: [PATCH] Bug 30243: When branccode is required on OPAC suggestion page
> default to empty value
>
>To test:
>1. Apply patch
>2. Go the purchase suggestion page and see that branchcode defaults to the first option in the list.
>3. Go to OPACSuggestionMandatoryFields and mark branchcode as required
>4. BAck on the OPAC suggestion page notice that the branchcode defaults to an empty value
>5. Try to submit the form without changing it, you cannot. You must choose a branch
>
>https://bugs.koha-community.org/show_bug.cgi?id=29795
>---
> koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-suggestions.tt | 1 +
> 1 file changed, 1 insertion(+)
>
>diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-suggestions.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-suggestions.tt
>index 89e1175c3f..cd62151ca6 100644
>--- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-suggestions.tt
>+++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-suggestions.tt
>@@ -188,6 +188,7 @@
>                                                 [% IF ( branchcode_required ) %]
>                                                     <label for="branch" class="required">Library:</label>
>                                                     <select name="branchcode" id="branch" required="required">
>+                                                        <option value=""></option>
>                                                         [% PROCESS options_for_libraries libraries => Branches.all( selected => branch ) %]
>                                                     </select>
>                                                     <div class="required_label required">Required</div>
>-- 
>2.20.1

Actions: View | Diff | Splinter Review

Attachments on bug 30243: 131525 | 131526 | 131580 | 132615