Attachment 131538 Details for Bug 28840 – Bug 28840: Better texts in batch record modification/deletion

[patch] Bug 28840: Better texts in batch record modification/deletion

Bug-28840-Better-texts-in-batch-record-modificatio.patch (text/plain), 7.13 KB, created by Fridolin Somers on 2022-03-10 05:59:04 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Fridolin Somers

Created: 2022-03-10 05:59:04 UTC

Size: 7.13 KB

patch

obsolete

>From 4c4440d740d887bc6ecc2b6c862b26bd15dfbab9 Mon Sep 17 00:00:00 2001
>From: Fridolin Somers <fridolin.somers@biblibre.com>
>Date: Tue, 10 Aug 2021 12:03:58 -1000
>Subject: [PATCH] Bug 28840: Better texts in batch record modification/deletion
>
>Tools batch record modification/deletion form contains texts in legends, labels, hints.
>
>I feel like :
>Labels are sometimes too long, showing them on multi-lines, like "Modify record using the following template". Long texts should be in legend or hint.
>Legend are sometimes contains redundant text, like in tabs.
>Also I propose to use "record id" instead of "record number".
>
>Test plan :
>Compare texts in page without and with patch
>---
> .../prog/en/modules/tools/batch_delete_records.tt  | 10 ++++------
> .../en/modules/tools/batch_record_modification.tt  | 14 ++++++--------
> 2 files changed, 10 insertions(+), 14 deletions(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/tools/batch_delete_records.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/tools/batch_delete_records.tt
>index 469ec64868..6fb17d7619 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/tools/batch_delete_records.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/tools/batch_delete_records.tt
>@@ -70,12 +70,11 @@
>         <ul>
>           <li><a href="#uploadfile_tab">Upload a file</a></li>
>           [% IF lists.count %]<li id="show_list_option"><a href="#shelves_tab">Select a list of records</a></li>[% END %]
>-          <li><a href="#enterlist_tab">Enter a list of record numbers</a></li>
>+          <li><a href="#enterlist_tab">Enter a list of record ids</a></li>
>         </ul>
> 
>         <div id="uploadfile_tab">
>           <fieldset class="rows">
>-            <legend>Use a file</legend>
>             <ol>
>               <li><label for="uploadfile">File: </label> <input type="file" id="uploadfile" name="uploadfile" /></li>
>             </ol>
>@@ -86,10 +85,9 @@
>         [% IF lists.count %]
>             <div id="shelves_tab">
>               <fieldset class="rows">
>-                <legend>Or select a list of records</legend>
>                 <ol>
>                   <li>
>-                    <label for="shelf_number">Use records from the following list: </label>
>+                    <label for="shelf_number">List: </label>
>                     <select name="shelf_number" id="shelf_number">
>                       <option value="">Select a list</option>
>                         [% FOREACH list IN lists %]
>@@ -106,11 +104,11 @@
> 
>         <div id="enterlist_tab">
>           <fieldset class="rows">
>-            <legend>Or enter a list of record numbers</legend>
>             <ol>
>               <li>
>-                <label for="recordnumber_list">List of biblionumbers or authority ids (one per line): </label>
>+                <label for="recordnumber_list">Ids: </label>
>                 <textarea rows="10" cols="30" id="recordnumber_list" name="recordnumber_list"></textarea>
>+                <div class="hint">Enter a list of biblionumbers or authority ids, one per line.</div>
>               </li>
>             </ol>
>           </fieldset>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/tools/batch_record_modification.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/tools/batch_record_modification.tt
>index a88f84c6b2..0378a8d97b 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/tools/batch_record_modification.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/tools/batch_record_modification.tt
>@@ -78,12 +78,11 @@
>                                 <ul>
>                                     <li><a href="#uploadfile_tab">Upload a file</a></li>
>                                         [% IF lists.count %]<li id="show_list_option"><a href="#shelves_tab">Select a list of records</a></li>[% END %]
>-                                    <li><a href="#enterlist_tab">Enter a list of record numbers</a></li>
>+                                    <li><a href="#enterlist_tab">Enter a list of record ids</a></li>
>                                 </ul>
> 
>                                 <div id="uploadfile_tab">
>                                     <fieldset class="rows">
>-                                        <legend>Use a file</legend>
>                                         <ol>
>                                             <li><label for="uploadfile">File: </label> <input type="file" id="uploadfile" name="uploadfile" /></li>
>                                         </ol>
>@@ -94,10 +93,9 @@
>                                 [% IF lists.count %]
>                                     <div id="shelves_tab">
>                                         <fieldset class="rows">
>-                                            <legend>Or select a list of records</legend>
>                                             <ol>
>                                                 <li>
>-                                                    <label for="shelf_number">Use records from the following list: </label>
>+                                                    <label for="shelf_number">List: </label>
>                                                     <select name="shelf_number" id="shelf_number">
>                                                         <option value="">Select a list</option>
>                                                         [% FOREACH list IN lists %]
>@@ -114,11 +112,11 @@
> 
>                                 <div id="enterlist_tab">
>                                     <fieldset class="rows">
>-                                        <legend>Or enter a list of record numbers</legend>
>                                         <ol>
>                                             <li>
>-                                                <label for="recordnumber_list">List of biblionumbers or authority ids (one per line): </label>
>+                                                <label for="recordnumber_list">Ids: </label>
>                                                 <textarea rows="10" cols="30" id="recordnumber_list" name="recordnumber_list"></textarea>
>+                                                <div class="hint">Enter a list of biblionumbers or authority ids, one per line.</div>
>                                             </li>
>                                         </ol>
>                                     </fieldset>
>@@ -128,10 +126,10 @@
>                             </div> 
> 
>                             <fieldset class="rows">
>-                                <legend>Use MARC modification template:</legend>
>+                                <legend>MARC modification template</legend>
>                                 <ol>
>                                     <li>
>-                                        <label for="marc_modification_template_id" class="required">Modify record using the following template: </label>
>+                                        <label for="marc_modification_template_id" class="required">Template: </label>
>                                         <select name="marc_modification_template_id" id="marc_modification_template_id" required="required">
>                                             <option value="">Select a template</option>
>                                             [% FOREACH mmt IN MarcModificationTemplatesLoop %]
>-- 
>2.35.1

Actions: View | Diff | Splinter Review

Attachments on bug 28840: 123723 | 123724 | 123725 | 131538 | 131781 | 133713 | 133714 | 133729