Bugzilla – Attachment 131576 Details for
Bug 29936
Add ability to disable hold capture via SIP checkin
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 29936: Add holds_get_captured option to sip config
Bug-29936-Add-holdsgetcaptured-option-to-sip-confi.patch (text/plain), 4.14 KB, created by
Martin Renvoize (ashimema)
on 2022-03-10 16:50:44 UTC
(
hide
)
Description:
Bug 29936: Add holds_get_captured option to sip config
Filename:
MIME Type:
Creator:
Martin Renvoize (ashimema)
Created:
2022-03-10 16:50:44 UTC
Size:
4.14 KB
patch
obsolete
>From 844c0f4e88f461a4b4cd5ce9dfa3914c261023a2 Mon Sep 17 00:00:00 2001 >From: Martin Renvoize <martin.renvoize@ptfs-europe.com> >Date: Thu, 10 Mar 2022 13:53:17 +0000 >Subject: [PATCH] Bug 29936: Add holds_get_captured option to sip config > >This patch adds a new option to the SIP config, allowing for hold >capture to be disabled on difference devices. We still notice the hold >and alert the user, but we do not trigger the update in the system to >mark the hold as found (waiting, processing or in transit). > >Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> >Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk> >--- > C4/SIP/ILS/Transaction/Checkin.pm | 29 ++++++++++++++++------------- > debian/templates/SIPconfig.xml | 1 + > etc/SIPconfig.xml | 1 + > 3 files changed, 18 insertions(+), 13 deletions(-) > >diff --git a/C4/SIP/ILS/Transaction/Checkin.pm b/C4/SIP/ILS/Transaction/Checkin.pm >index a4e09304ac..e8d9decc1b 100644 >--- a/C4/SIP/ILS/Transaction/Checkin.pm >+++ b/C4/SIP/ILS/Transaction/Checkin.pm >@@ -50,9 +50,10 @@ sub do_checkin { > my $return_date = shift; > my $account = shift; > >- my $checked_in_ok = $account->{checked_in_ok}; >- my $cv_triggers_alert = $account->{cv_triggers_alert}; >- my $holds_block_checkin = $account->{holds_block_checkin}; >+ my $checked_in_ok = $account->{checked_in_ok}; >+ my $cv_triggers_alert = $account->{cv_triggers_alert}; >+ my $holds_block_checkin = $account->{holds_block_checkin}; >+ my $holds_get_captured = $account->{holds_get_captured} // 1; > > if (!$branch) { > $branch = 'SIP2'; >@@ -141,20 +142,22 @@ sub do_checkin { > } elsif ($branch eq $messages->{ResFound}->{branchcode}) { > $self->hold($messages->{ResFound}); > $self->alert_type('01'); >- ModReserveAffect( $messages->{ResFound}->{itemnumber}, >- $messages->{ResFound}->{borrowernumber}, 0, $messages->{ResFound}->{reserve_id}); >+ ModReserveAffect( >+ $messages->{ResFound}->{itemnumber}, >+ $messages->{ResFound}->{borrowernumber}, >+ 0, $messages->{ResFound}->{reserve_id} >+ ) if $holds_get_captured; > > } else { > $self->hold($messages->{ResFound}); > $self->alert_type('02'); >- ModReserveAffect( $item->itemnumber, >- $messages->{ResFound}->{borrowernumber}, 1, $messages->{ResFound}->{reserve_id}); >- ModItemTransfer( $item->itemnumber, >- $branch, >- $messages->{ResFound}->{branchcode}, >- 'Reserve', >- ); >- >+ if ($holds_get_captured) { >+ ModReserveAffect( $item->itemnumber, >+ $messages->{ResFound}->{borrowernumber}, >+ 1, $messages->{ResFound}->{reserve_id} ); >+ ModItemTransfer( $item->itemnumber, $branch, >+ $messages->{ResFound}->{branchcode}, 'Reserve', ); >+ } > } > $self->{item}->hold_patron_id( $messages->{ResFound}->{borrowernumber} ); > $self->{item}->destination_loc( $messages->{ResFound}->{branchcode} ); >diff --git a/debian/templates/SIPconfig.xml b/debian/templates/SIPconfig.xml >index 413e06d1ab..64882c4ff5 100644 >--- a/debian/templates/SIPconfig.xml >+++ b/debian/templates/SIPconfig.xml >@@ -53,6 +53,7 @@ > send_patron_home_library_in_af="1" > av_field_template="[% accountline.description %] [% accountline.amountoutstanding | format('%.2f') %]" > holds_block_checkin="0" >+ holds_get_captured="1" > overdues_block_checkout="1" > format_due_date="0"> > <screen_msg_regex find="Greetings from Koha." replace="Welcome to your library!" /> >diff --git a/etc/SIPconfig.xml b/etc/SIPconfig.xml >index 9e94594bdd..46d39a7638 100644 >--- a/etc/SIPconfig.xml >+++ b/etc/SIPconfig.xml >@@ -70,6 +70,7 @@ > hide_fields="BD,BE,BF,PB" > register_id='' > holds_block_checkin="0" >+ holds_get_captured="1" > prevcheckout_block_checkout="0" > overdues_block_checkout="1" > format_due_date="0"> >-- >2.20.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 29936
:
131555
|
131556
|
131575
|
131576
|
131577
|
131578
|
133763
|
133764
|
133765