Bugzilla – Attachment 131580 Details for
Bug 30243
When OPACSuggestionMandatoryFields includes branchcode the dropdown should default to an empty value
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 30243: When branccode is required on OPAC suggestion page default to empty value
Bug-30243-When-branccode-is-required-on-OPAC-sugge.patch (text/plain), 1.77 KB, created by
Shi Yao Wang
on 2022-03-10 19:13:38 UTC
(
hide
)
Description:
Bug 30243: When branccode is required on OPAC suggestion page default to empty value
Filename:
MIME Type:
Creator:
Shi Yao Wang
Created:
2022-03-10 19:13:38 UTC
Size:
1.77 KB
patch
obsolete
>From aadbd4d3882ab76704748402eabef224de2f47ca Mon Sep 17 00:00:00 2001 >From: Lucas Gass <lucas@bywatersolutions.com> >Date: Wed, 9 Mar 2022 14:55:21 +0000 >Subject: [PATCH] Bug 30243: When branccode is required on OPAC suggestion page > default to empty value > >To test: >1. Apply patch >2. Go the purchase suggestion page and see that branchcode defaults to the first option in the list. >3. Go to OPACSuggestionMandatoryFields and mark branchcode as required >4. BAck on the OPAC suggestion page notice that the branchcode defaults to an empty value >5. Try to submit the form without changing it, you cannot. You must choose a branch > >Signed-off-by: shiyao <shiyao@inlibro.com> >--- > koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-suggestions.tt | 1 + > 1 file changed, 1 insertion(+) > >diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-suggestions.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-suggestions.tt >index 89e1175c3f..cd62151ca6 100644 >--- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-suggestions.tt >+++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-suggestions.tt >@@ -188,6 +188,7 @@ > [% IF ( branchcode_required ) %] > <label for="branch" class="required">Library:</label> > <select name="branchcode" id="branch" required="required"> >+ <option value=""></option> > [% PROCESS options_for_libraries libraries => Branches.all( selected => branch ) %] > </select> > <div class="required_label required">Required</div> >-- >2.25.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 30243
:
131525
|
131526
|
131580
|
132615