Bugzilla – Attachment 131585 Details for
Bug 25285
Wrong message when plugin required Koha version isn't met
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 25285: Fix wrong message about required Koha version in plugins
Bug-25285-Fix-wrong-message-about-required-Koha-ve.patch (text/plain), 2.46 KB, created by
Martin Renvoize (ashimema)
on 2022-03-11 12:04:29 UTC
(
hide
)
Description:
Bug 25285: Fix wrong message about required Koha version in plugins
Filename:
MIME Type:
Creator:
Martin Renvoize (ashimema)
Created:
2022-03-11 12:04:29 UTC
Size:
2.46 KB
patch
obsolete
>From 26d3a918bf652ff7ed51f331bab4b5241bdae2a4 Mon Sep 17 00:00:00 2001 >From: Tomas Cohen Arazi <tomascohen@theke.io> >Date: Wed, 9 Mar 2022 08:23:38 -0300 >Subject: [PATCH] Bug 25285: Fix wrong message about required Koha version in > plugins > >When you install a plugin that requires a newer Koha version, it reports >this: > ><< >Warning: This report was written for a newer version of Koha. Run at your own risk. >>> > >It is wrong in a couple ways: >- It is not a report. >- It feels like it dates back to when plugins were only run i.e. > pre-hooks, etc. > >This patch proposes a change to reflect this. > >To test: >1. Verify the string changes make sense to you >2. Sign off :-D > >Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> >Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> >Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> >--- > .../intranet-tmpl/prog/en/modules/plugins/plugins-home.tt | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/plugins/plugins-home.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/plugins/plugins-home.tt >index 55ff28663a..08e78a0c2a 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/plugins/plugins-home.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/plugins/plugins-home.tt >@@ -153,13 +153,13 @@ > > [% IF ( plugin.metadata.minimum_version && koha_version < plugin.metadata.minimum_version ) %] > <div class="dialog alert"> >- Warning: This report was written for a newer version of Koha. Run at your own risk. >+ Warning: This plugin was written for a newer version of Koha. Use at your own risk. > </div> > [% END %] > > [% IF ( plugin.metadata.maximum_version && koha_version > plugin.metadata.maximum_version ) %] > <div class="dialog alert"> >- Warning: This plugin was written for an older version of Koha. Run at your own risk. >+ Warning: This plugin was written for an older version of Koha. Use at your own risk. > </div> > [% END %] > </td> >-- >2.20.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 25285
:
131517
|
131531
| 131585