Bugzilla – Attachment 131588 Details for
Bug 30244
Hide lost items not respected in OPAC results XSLT
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 30244: Include lost items in list of hidden items
Bug-30244-Include-lost-items-in-list-of-hidden-ite.patch (text/plain), 1.47 KB, created by
Nick Clemens (kidclamp)
on 2022-03-11 14:28:24 UTC
(
hide
)
Description:
Bug 30244: Include lost items in list of hidden items
Filename:
MIME Type:
Creator:
Nick Clemens (kidclamp)
Created:
2022-03-11 14:28:24 UTC
Size:
1.47 KB
patch
obsolete
>From 648353c8bda8a9e53673a7e55b96a0e19921a791 Mon Sep 17 00:00:00 2001 >From: Nick Clemens <nick@bywatersolutions.com> >Date: Fri, 11 Mar 2022 14:24:27 +0000 >Subject: [PATCH] Bug 30244: Include lost items in list of hidden items > >When building search results for XSLT we generate and pass a list of hidden >itemnumbers. > >We do skip the lost items in our parsing, however, we neglect to add the itemnumber >to the hidden list > >This patch simply adds the lost itemnumbers to the list > >There is more work to be done here to simpliofy this process, however, this patch resolves >the issue and can be backported to stable branches > >To test: >1 - Set systempreference hidelostitems to "Don't show" >2 - Edit a record to set one item as lost and one as available >3 - Perform an OPAC search that returns the record above >4 - Note that the lost item shows in availability line >5 - Click on the record - note the lost item does not show on details >6 - Apply patch >7 - Reload search results >8 - Lost itme no longer displays >--- > C4/Search.pm | 1 + > 1 file changed, 1 insertion(+) > >diff --git a/C4/Search.pm b/C4/Search.pm >index 96013e28dd..6825b2ed7a 100644 >--- a/C4/Search.pm >+++ b/C4/Search.pm >@@ -1804,6 +1804,7 @@ sub searchResults { > if ($is_opac) { > # hidden because lost > if ($hidelostitems && $item->{itemlost}) { >+ push @hiddenitems, $item->{itemnumber}; > $hideatopac_count++; > next; > } >-- >2.30.2
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 30244
:
131588
|
131591
|
132193