Bugzilla – Attachment 131640 Details for
Bug 17015
New Koha Calendar
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 17015: Automatically update calendar when creating or deleting a branch
Bug-17015-Automatically-update-calendar-when-creat.patch (text/plain), 2.68 KB, created by
Michal Denar
on 2022-03-11 21:55:32 UTC
(
hide
)
Description:
Bug 17015: Automatically update calendar when creating or deleting a branch
Filename:
MIME Type:
Creator:
Michal Denar
Created:
2022-03-11 21:55:32 UTC
Size:
2.68 KB
patch
obsolete
>From 8d7ae5e8c554ceade24bb2f50ca659077d595fb4 Mon Sep 17 00:00:00 2001 >From: Charles Farmer <charles.farmer@inLibro.com> >Date: Wed, 4 Mar 2020 16:04:05 -0500 >Subject: [PATCH] Bug 17015: Automatically update calendar when creating or > deleting a branch > >Signed-off-by: Michal Denar <black23@gmail.com> >--- > Koha/DiscreteCalendar.pm | 41 ++++++++++++++++++++++++++++++++++++++++ > admin/branches.pl | 3 +++ > 2 files changed, 44 insertions(+) > >diff --git a/Koha/DiscreteCalendar.pm b/Koha/DiscreteCalendar.pm >index 4875e7c189..f80916305b 100644 >--- a/Koha/DiscreteCalendar.pm >+++ b/Koha/DiscreteCalendar.pm >@@ -175,6 +175,16 @@ sub add_new_branch { > branchcode => $copyBranch > }); > >+ unless ($branch_rs->count) { >+ $copyBranch = Koha::Libraries->next->branchcode; >+ $branch_rs = $schema->resultset('DiscreteCalendar')->search({ >+ branchcode => $copyBranch >+ }); >+ } >+ >+ $schema->{AutoCommit} = 0; >+ $schema->storage->txn_begin; >+ > while (my $row = $branch_rs->next()) { > $schema->resultset('DiscreteCalendar')->create({ > date => $row->date(), >@@ -186,8 +196,39 @@ sub add_new_branch { > }); > } > >+ eval { $schema->storage->txn_commit; }; >+ >+ if ($@) { >+ $schema->storage->rollback; >+ } >+ >+ $schema->{AutoCommit} = 1; > } > >+=head2 delete_branch >+ >+ Koha::DiscreteCalendar->delete_branch($branchcode) >+ >+This method will delete every discrete_calendar entry for a given branch >+C<$branchcode> is the code of the branch we want to remove from the table >+ >+=cut >+ >+sub delete_branch { >+ my ( $classname, $branchcode ) = @_; >+ >+ my $schema = Koha::Database->new->schema; >+ >+ my $branch_rs = $schema->resultset('DiscreteCalendar')->search({ >+ branchcode => $branchcode >+ }); >+ >+ if ($branch_rs->count) { >+ $branch_rs->delete; >+ } >+} >+ >+ > =head2 get_date_info > > my $date = $calendar->get_date_info; >diff --git a/admin/branches.pl b/admin/branches.pl >index 08a73f6571..34f6d2b594 100755 >--- a/admin/branches.pl >+++ b/admin/branches.pl >@@ -148,6 +148,8 @@ if ( $op eq 'add_form' ) { > } > } > >+ Koha::DiscreteCalendar->add_new_branch(undef, $branchcode); >+ > push @messages, { type => 'message', code => 'success_on_insert' }; > } > ); >@@ -193,6 +195,7 @@ if ( $op eq 'add_form' ) { > if ( $@ or not $deleted ) { > push @messages, { type => 'alert', code => 'error_on_delete' }; > } else { >+ Koha::DiscreteCalendar->delete_branch($branchcode); > push @messages, { type => 'message', code => 'success_on_delete' }; > } > $op = 'list'; >-- >2.30.2
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 17015
:
53859
|
54318
|
54419
|
59166
|
59167
|
59168
|
59169
|
59170
|
59171
|
59267
|
59268
|
59269
|
59270
|
59271
|
59463
|
59516
|
59517
|
59518
|
59519
|
59520
|
59561
|
59562
|
59586
|
59587
|
59888
|
59889
|
60902
|
60903
|
60904
|
60905
|
60906
|
60986
|
61737
|
62375
|
62376
|
62380
|
63257
|
63282
|
63362
|
63363
|
63364
|
63365
|
63366
|
63367
|
64235
|
65073
|
65074
|
65075
|
65076
|
65077
|
67721
|
67722
|
67723
|
67724
|
67725
|
67879
|
67929
|
67930
|
67931
|
67932
|
67933
|
67934
|
68392
|
68393
|
68394
|
68395
|
68396
|
68397
|
71634
|
71635
|
71636
|
71637
|
71638
|
72890
|
73145
|
74859
|
74860
|
74861
|
74862
|
74863
|
74864
|
74865
|
74866
|
75444
|
75479
|
76594
|
77249
|
77250
|
77607
|
77608
|
77609
|
77610
|
77611
|
77612
|
77613
|
77770
|
77771
|
77772
|
77773
|
77774
|
79035
|
80523
|
80524
|
80525
|
80526
|
80527
|
80528
|
80529
|
80530
|
80531
|
80532
|
80533
|
80534
|
80535
|
83547
|
85394
|
85677
|
85678
|
85679
|
85680
|
85681
|
85682
|
85683
|
85684
|
85685
|
85686
|
85687
|
85688
|
85689
|
85690
|
85691
|
92595
|
92596
|
92597
|
92598
|
100079
|
110383
|
110384
|
110386
|
110387
|
110388
|
110389
|
113541
|
113905
|
115501
|
115502
|
115503
|
115504
|
115505
|
115506
|
115507
|
115508
|
115509
|
115510
|
115511
|
118554
|
118555
|
118556
|
118557
|
118558
|
118559
|
119095
|
119097
|
119099
|
119100
|
119101
|
119102
|
131619
|
131620
|
131621
|
131622
|
131623
|
131624
|
131625
|
131626
|
131634
|
131635
|
131636
|
131637
|
131638
|
131639
|
131640
|
131641
|
131667
|
132199
|
133596
|
133597
|
133598
|
133599
|
133600
|
133601
|
133602
|
133603
|
133604
|
133605
|
133678
|
137219
|
137220
|
137221
|
137222
|
137223
|
137224
|
137225
|
137226
|
137227
|
137228
|
137229
|
139378
|
139379
|
139380
|
139381
|
139382
|
139599
|
139600
|
139601
|
139602
|
139603
|
139851
|
140150
|
141176
|
144257
|
144258
|
144259
|
144260
|
144261
|
144262
|
144264
|
144268
|
144269
|
144270
|
144271
|
144272
|
144273
|
151438
|
151439
|
151440
|
151441
|
151442
|
151443
|
151444
|
151445
|
151446
|
151447
|
151448
|
151449
|
151450
|
156340
|
156341
|
156342
|
156343
|
156344
|
156345
|
156346
|
156347
|
156348
|
156349
|
156350
|
156351
|
156352
|
156353
|
156354
|
156355
|
157656
|
157657
|
157658
|
157659
|
157660
|
157661
|
157662
|
157663
|
157664
|
157665
|
157666
|
157667
|
157668
|
157669
|
157670
|
157671
|
157672
|
167805
|
167806
|
167807
|
167808
|
167809