Attachment 131642 Details for Bug 30282 – Bug 30282: overdues report does not display subtitle, part_name, part_number

[patch] Bug 30282: overdues report does not display subtitle, part_name, part_number

Bug-30282-overdues-report-does-not-display-subtitl.patch (text/plain), 2.03 KB, created by Lucas Gass (lukeg) on 2022-03-11 23:01:49 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Lucas Gass (lukeg)

Created: 2022-03-11 23:01:49 UTC

Size: 2.03 KB

patch

obsolete

>From 2af53ab2643489f58e9181040acce0de70a9c570 Mon Sep 17 00:00:00 2001
>From: Blou <blou@inlibro.com>
>Date: Fri, 11 Mar 2022 15:54:51 -0500
>Subject: [PATCH] Bug 30282: overdues report does not display subtitle,
> part_name, part_number
>
>In circ/overdue.pl, the Title column is the result of includes/biblio-title.inc display.  The code of biblio-title.inc means to display subtitle, part_number and part_name from biblio table, but nothing but commas show up because those fields are never retrieved by overdue.pl
>
>To reproduce:
>1) have an item whose biblio.subtitle, part_name and part_number and non-empty.
>2) issue it, then set it late (overdue).
>3) go to the report page (circ/overdue.pl) and make it appear.
>4) subtitle, part_number and part_name do not appear, although they are meant to by biblio-title.inc code
>5) apply the patch and try again.
>
>It's a simple fix of adding the fields in the database query.
>
>Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
>---
> circ/overdue.pl | 6 ++++++
> 1 file changed, 6 insertions(+)
>
>diff --git a/circ/overdue.pl b/circ/overdue.pl
>index d6ae428e39..178ec03041 100755
>--- a/circ/overdue.pl
>+++ b/circ/overdue.pl
>@@ -245,6 +245,9 @@ if ($noreport) {
>         items.holdingbranch,
>         items.location,
>         biblio.title,
>+        biblio.subtitle,
>+        biblio.part_number,
>+        biblio.part_name,
>         biblio.author,
>         biblio.biblionumber,
>         items.itemcallnumber,
>@@ -333,6 +336,9 @@ if ($noreport) {
>             issuedate              => output_pref({ dt => dt_from_string( $data->{issuedate} ), dateonly => 1 }),
>             biblionumber           => $data->{biblionumber},
>             title                  => $data->{title},
>+            subtitle               => $data->{subtitle},
>+            part_number            => $data->{part_number},
>+            part_name              => $data->{part_name},
>             author                 => $data->{author},
>             homebranchcode         => $data->{homebranch},
>             holdingbranchcode      => $data->{holdingbranch},
>-- 
>2.20.1

Actions: View | Diff | Splinter Review

Attachments on bug 30282: 131632 | 131642 | 132011