Bugzilla – Attachment 131675 Details for
Bug 25251
When a record has no items click delete all does not need an alert
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 25251: Remove alert from disabled buttons
Bug-25251-Remove-alert-from-disabled-buttons.patch (text/plain), 1.51 KB, created by
Owen Leonard
on 2022-03-14 18:35:24 UTC
(
hide
)
Description:
Bug 25251: Remove alert from disabled buttons
Filename:
MIME Type:
Creator:
Owen Leonard
Created:
2022-03-14 18:35:24 UTC
Size:
1.51 KB
patch
obsolete
>From 5ed6543b4e6fcc0c5432b8fca71e2433b7707724 Mon Sep 17 00:00:00 2001 >From: Nick Clemens <nick@bywatersolutions.com> >Date: Mon, 14 Mar 2022 17:05:56 +0000 >Subject: [PATCH] Bug 25251: Remove alert from disabled buttons > >This patch removes the alert, but adds a stopPropagation call >in order to not close the menu when the disabled buttons are clicked > >To test: >1 - Find a record with items in the staff interface >2 - Click edit >3 - Note 'Edit items in a batch, 'Delete items in a batch', and 'Delete > all items' are grayed out >4 - Note hovering displays a note that there are no items >5 - Click on each anyway, an alert is generated, menu is closed >6 - Apply patch >7 - Reload page >8 - Click on each disabled option and confirm > - there is no more alert > - the menu does not close >9 - Confirm tooltip is displayed > >Signed-off-by: Owen Leonard <oleonard@myacpl.org> >--- > koha-tmpl/intranet-tmpl/prog/js/catalog.js | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/js/catalog.js b/koha-tmpl/intranet-tmpl/prog/js/catalog.js >index 2d63aecb81..7b40873f20 100644 >--- a/koha-tmpl/intranet-tmpl/prog/js/catalog.js >+++ b/koha-tmpl/intranet-tmpl/prog/js/catalog.js >@@ -124,8 +124,7 @@ $(document).ready(function() { > $("#deletebiblio").tooltip(); > $("#batchedit-disabled,#batchdelete-disabled,#deleteallitems-disabled") > .on("click",function(e){ >- e.preventDefault(); >- alertNoItems(); >+ e.stopPropagation(); > }) > .tooltip(); > >-- >2.20.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 25251
:
131669
|
131674
|
131675
|
132012
|
132029
|
132030