Bugzilla – Attachment 131794 Details for
Bug 29915
Anonymous session generates 1 new session ID per hit
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 29915: (QA follow-up) Add a comment in checkauth on $flags
Bug-29915-QA-follow-up-Add-a-comment-in-checkauth-.patch (text/plain), 1.08 KB, created by
Martin Renvoize (ashimema)
on 2022-03-16 14:08:44 UTC
(
hide
)
Description:
Bug 29915: (QA follow-up) Add a comment in checkauth on $flags
Filename:
MIME Type:
Creator:
Martin Renvoize (ashimema)
Created:
2022-03-16 14:08:44 UTC
Size:
1.08 KB
patch
obsolete
>From d31d0c7991988f336efb158c4cc6a799bdb7ac92 Mon Sep 17 00:00:00 2001 >From: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> >Date: Wed, 26 Jan 2022 15:54:28 +0000 >Subject: [PATCH] Bug 29915: (QA follow-up) Add a comment in checkauth on > $flags > >This is quite a misleading call. > >Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> >Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >Signed-off-by: Nick Clemens <nick@bywatersolutions.com> >Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> >--- > C4/Auth.pm | 1 + > 1 file changed, 1 insertion(+) > >diff --git a/C4/Auth.pm b/C4/Auth.pm >index a48eaa009b..88dc23165f 100644 >--- a/C4/Auth.pm >+++ b/C4/Auth.pm >@@ -883,6 +883,7 @@ sub checkauth { > } > elsif ( $sessionID = $query->cookie("CGISESSID") ) { # assignment, not comparison > my ( $return, $more_info ); >+ # NOTE: $flags in the following call is still undefined ! > ( $return, $session, $more_info ) = check_cookie_auth( $sessionID, $flags, > { remote_addr => $ENV{REMOTE_ADDR}, skip_version_check => 1 } > ); >-- >2.20.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 29915
:
129644
|
129653
|
129683
|
129748
|
129750
|
129751
|
129752
|
129753
|
129754
|
129755
|
129756
|
129822
|
129826
|
129827
|
129828
|
129829
|
129830
|
129831
|
129832
|
129833
|
129860
|
129861
|
129862
|
129863
|
129864
|
129865
|
129866
|
129878
|
129879
|
129880
|
129882
|
129883
|
129884
|
129885
|
129886
|
129887
|
129888
|
129889
|
129906
|
129907
|
129908
|
129909
|
129910
|
129911
|
129912
|
129913
|
129951
|
130596
|
130597
|
130598
|
130599
|
130600
|
130601
|
130602
|
130603
|
130604
|
131708
|
131709
|
131710
|
131711
|
131712
|
131713
|
131714
|
131715
|
131716
|
131788
|
131789
|
131790
|
131791
|
131792
|
131793
| 131794 |
131795
|
131796
|
131797
|
132101
|
132104
|
132114
|
132158
|
132159